fix: remove margin from icon when ToolbarButton is vertical #28658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 12 | 14 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 587 | 577 | 5000 | |
| Button | mount | 290 | 285 | 5000 | |
| Field | mount | 1044 | 1079 | 5000 | |
| FluentProvider | mount | 634 | 671 | 5000 | |
| FluentProviderWithTheme | mount | 87 | 82 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 61 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 70 | 67 | 10 | |
| InfoButton | mount | 12 | 14 | 5000 | Possible regression |
| MakeStyles | mount | 816 | 856 | 50000 | |
| Persona | mount | 1612 | 1562 | 5000 | |
| SpinButton | mount | 1324 | 1337 | 5000 |
stsaklas
approved these changes
Jul 27, 2023
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 32a2eb3:
|
📊 Bundle size reportUnchanged fixtures
|
fabricteam
reviewed
Jul 27, 2023
change/@fluentui-react-toolbar-d17fdf5d-7561-468e-b616-f1bbe8f690d5.json
Show resolved
Hide resolved
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6320eca143cfe0741e35ada6a84408036332d176 (build) |
ling1726
approved these changes
Jul 27, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 1, 2023
* master: (37 commits) release (microsoft#28696) Fixing re-render issue for all charts when empty (microsoft#28321) feat(FluentProvider): emit errors on duplicate IDs (microsoft#28670) applying package updates fix(react-positioning): autoSize causing position update to reach maximum (microsoft#28689) fix(react-tags-preview): fix InteractionTag hover styles (microsoft#28686) Accordion: export AccordionHeaderProvider (microsoft#28542) feat(react-shared-contexts): add AnnounceContext (microsoft#28654) Added VR tests for Breadcrumb (microsoft#28653) fix(react-menu): use outline for menuItem focus ring (microsoft#28685) [Bug]: Tree, vertical spacing of branches and children is inconsistent (microsoft#28681) feaTt(react-tree): adds openItems and checkedItems to tree callback data (microsoft#28669) applying package updates Add mountNode prop to combos (microsoft#28661) react-tags-preview: add more vr test (microsoft#28582) chore: migrate to nx 16.1.4 (microsoft#28583) applying package updates chore: improves internal headless signature (microsoft#28651) fix: remove margin from icon when ToolbarButton is vertical (microsoft#28658) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove margin from icon inside ToolbarButton when vertical.
Before:
After: