Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-link): migrate to new package structure #25471

Merged
merged 2 commits into from
Nov 1, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3aafd7a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Nov 1, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: abfb64d82916efdb0e5129cf41081a13e4e9d9ff (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 1, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-link
Link
11.852 kB
4.888 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against abfb64d82916efdb0e5129cf41081a13e4e9d9ff

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 1, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1301 1304 5000
Button mount 929 938 5000
FluentProvider mount 1603 1633 5000
FluentProviderWithTheme mount 625 631 10
FluentProviderWithTheme virtual-rerender 598 596 10
FluentProviderWithTheme virtual-rerender-with-unmount 618 618 10
MakeStyles mount 1939 1935 50000
SpinButton mount 2530 2554 5000

@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 1, 2022 19:23
@TristanWatanabe TristanWatanabe requested review from a team as code owners November 1, 2022 19:23
@TristanWatanabe TristanWatanabe merged commit a64b05e into microsoft:master Nov 1, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-link branch November 1, 2022 23:16
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2022
* master: (23 commits)
  fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385)
  applying package updates
  feat: Implement child render function for DataGrid rows (microsoft#25476)
  fix(useTable): sort should adapt to enhanced row types (microsoft#25487)
  applying package updates
  feat: positioning should happen out of React lifecycle (microsoft#25456)
  applying package updates
  chore(react-link): migrate to new package structure (microsoft#25471)
  chore(react-input): migrate to new package structure (microsoft#25469)
  fix glob pattern for syncpack (microsoft#25465)
  chore(react-label): migrate to new package structure (microsoft#25470)
  chore: bump Griffel to latest (microsoft#25412)
  chore: add few small toolbar improvements (microsoft#25468)
  docs: fix small typos (microsoft#25464)
  chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466)
  feat: v0 menu style migration from v9 (microsoft#25012)
  applying package updates
  Update List to render children on first render() call (microsoft#25331)
  Scaffold react-skeleton package (microsoft#25435)
  fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants