chore: bump Griffel to latest #25412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 78d042e6d3053da0902ef75330249dbaedc2493c (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 59b7f9c:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1662 | 1707 | 5000 | |
| Button | mount | 1141 | 1141 | 5000 | |
| FluentProvider | mount | 1948 | 1928 | 5000 | |
| FluentProviderWithTheme | mount | 718 | 717 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 653 | 680 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 700 | 689 | 10 | |
| MakeStyles | mount | 2268 | 2270 | 50000 | |
| SpinButton | mount | 3242 | 3238 | 5000 |
layershifter
requested review from
a team,
GeoffCoxMSFT,
sopranopillow,
tomi-msft,
chpalac,
ling1726,
behowell,
khmakoto,
spmonahan,
micahgodbolt and
smhigley
as code owners
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| IconMinimalPerf.default | 547 | 457 | 1.2:1 |
| AttachmentMinimalPerf.default | 121 | 104 | 1.16:1 |
| DividerMinimalPerf.default | 293 | 252 | 1.16:1 |
| LabelMinimalPerf.default | 309 | 267 | 1.16:1 |
| AlertMinimalPerf.default | 214 | 187 | 1.14:1 |
| HeaderSlotsPerf.default | 635 | 555 | 1.14:1 |
| ImageMinimalPerf.default | 307 | 272 | 1.13:1 |
| TextMinimalPerf.default | 276 | 246 | 1.12:1 |
| SliderMinimalPerf.default | 1310 | 1180 | 1.11:1 |
| LayoutMinimalPerf.default | 292 | 265 | 1.1:1 |
| VideoMinimalPerf.default | 608 | 560 | 1.09:1 |
| ListCommonPerf.default | 490 | 454 | 1.08:1 |
| MenuMinimalPerf.default | 702 | 649 | 1.08:1 |
| MenuButtonMinimalPerf.default | 1398 | 1303 | 1.07:1 |
| SegmentMinimalPerf.default | 256 | 239 | 1.07:1 |
| TreeMinimalPerf.default | 624 | 584 | 1.07:1 |
| ChatDuplicateMessagesPerf.default | 228 | 218 | 1.05:1 |
| DatepickerMinimalPerf.default | 4742 | 4497 | 1.05:1 |
| SkeletonMinimalPerf.default | 288 | 273 | 1.05:1 |
| TableManyItemsPerf.default | 1437 | 1367 | 1.05:1 |
| TreeWith60ListItems.default | 132 | 126 | 1.05:1 |
| AttachmentSlotsPerf.default | 940 | 904 | 1.04:1 |
| DropdownManyItemsPerf.default | 491 | 470 | 1.04:1 |
| InputMinimalPerf.default | 947 | 914 | 1.04:1 |
| PortalMinimalPerf.default | 144 | 139 | 1.04:1 |
| BoxMinimalPerf.default | 245 | 238 | 1.03:1 |
| ButtonMinimalPerf.default | 119 | 116 | 1.03:1 |
| CheckboxMinimalPerf.default | 1723 | 1675 | 1.03:1 |
| ListWith60ListItems.default | 521 | 512 | 1.02:1 |
| PopupMinimalPerf.default | 517 | 507 | 1.02:1 |
| ChatMinimalPerf.default | 538 | 535 | 1.01:1 |
| ListMinimalPerf.default | 377 | 372 | 1.01:1 |
| AvatarMinimalPerf.default | 134 | 134 | 1:1 |
| DialogMinimalPerf.default | 605 | 606 | 1:1 |
| RosterPerf.default | 1759 | 1765 | 1:1 |
| ProviderMinimalPerf.default | 333 | 333 | 1:1 |
| TableMinimalPerf.default | 324 | 324 | 1:1 |
| CarouselMinimalPerf.default | 338 | 342 | 0.99:1 |
| DropdownMinimalPerf.default | 2106 | 2137 | 0.99:1 |
| ItemLayoutMinimalPerf.default | 944 | 949 | 0.99:1 |
| RefMinimalPerf.default | 172 | 174 | 0.99:1 |
| TooltipMinimalPerf.default | 1906 | 1932 | 0.99:1 |
| CardMinimalPerf.default | 391 | 401 | 0.98:1 |
| EmbedMinimalPerf.default | 2937 | 3002 | 0.98:1 |
| FlexMinimalPerf.default | 224 | 229 | 0.98:1 |
| AnimationMinimalPerf.default | 412 | 428 | 0.96:1 |
| SplitButtonMinimalPerf.default | 3411 | 3560 | 0.96:1 |
| CustomToolbarPrototype.default | 2133 | 2227 | 0.96:1 |
| ToolbarMinimalPerf.default | 734 | 763 | 0.96:1 |
| AccordionMinimalPerf.default | 105 | 110 | 0.95:1 |
| ButtonOverridesMissPerf.default | 1011 | 1064 | 0.95:1 |
| LoaderMinimalPerf.default | 246 | 259 | 0.95:1 |
| StatusMinimalPerf.default | 529 | 554 | 0.95:1 |
| GridMinimalPerf.default | 248 | 264 | 0.94:1 |
| TextAreaMinimalPerf.default | 359 | 381 | 0.94:1 |
| ChatWithPopoverPerf.default | 266 | 291 | 0.91:1 |
| HeaderMinimalPerf.default | 263 | 292 | 0.9:1 |
| ProviderMergeThemesPerf.default | 941 | 1043 | 0.9:1 |
| RadioGroupMinimalPerf.default | 327 | 362 | 0.9:1 |
| ButtonSlotsPerf.default | 396 | 454 | 0.87:1 |
| ListNestedPerf.default | 401 | 459 | 0.87:1 |
| ReactionMinimalPerf.default | 266 | 305 | 0.87:1 |
| FormMinimalPerf.default | 271 | 317 | 0.85:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1191 | 1189 | 5000 | |
| Breadcrumb | mount | 2809 | 2806 | 1000 | |
| Checkbox | mount | 2628 | 2620 | 5000 | |
| CheckboxBase | mount | 2360 | 2388 | 5000 | |
| ChoiceGroup | mount | 4223 | 4264 | 5000 | |
| ComboBox | mount | 1182 | 1185 | 1000 | |
| CommandBar | mount | 9267 | 9243 | 1000 | |
| ContextualMenu | mount | 10151 | 10237 | 1000 | |
| DefaultButton | mount | 1361 | 1356 | 5000 | |
| DetailsRow | mount | 3365 | 3385 | 5000 | |
| DetailsRowFast | mount | 3360 | 3382 | 5000 | |
| DetailsRowNoStyles | mount | 3190 | 3218 | 5000 | |
| Dialog | mount | 2960 | 2932 | 1000 | |
| DocumentCardTitle | mount | 576 | 584 | 1000 | |
| Dropdown | mount | 3160 | 3144 | 5000 | |
| FocusTrapZone | mount | 1953 | 1971 | 5000 | |
| FocusZone | mount | 1896 | 1911 | 5000 | |
| GroupedList | mount | 1799 | 2047 | 2 | |
| GroupedList | virtual-rerender | 1094 | 1078 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 1613 | 1607 | 2 | |
| GroupedListV2 | mount | 564 | 559 | 2 | |
| GroupedListV2 | virtual-rerender | 543 | 549 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 559 | 565 | 2 | |
| IconButton | mount | 1797 | 1798 | 5000 | |
| Label | mount | 750 | 753 | 5000 | |
| Layer | mount | 4091 | 4074 | 5000 | |
| Link | mount | 838 | 841 | 5000 | |
| MenuButton | mount | 1592 | 1618 | 5000 | |
| MessageBar | mount | 2366 | 2338 | 5000 | |
| Nav | mount | 3058 | 3065 | 1000 | |
| OverflowSet | mount | 1392 | 1397 | 5000 | |
| Panel | mount | 2492 | 2496 | 1000 | |
| Persona | mount | 1247 | 1278 | 1000 | |
| Pivot | mount | 1513 | 1500 | 1000 | |
| PrimaryButton | mount | 1487 | 1492 | 5000 | |
| Rating | mount | 6975 | 6970 | 5000 | |
| SearchBox | mount | 1499 | 1500 | 5000 | |
| Shimmer | mount | 2926 | 2892 | 5000 | |
| Slider | mount | 2117 | 2109 | 5000 | |
| SpinButton | mount | 4271 | 4300 | 5000 | |
| Spinner | mount | 827 | 828 | 5000 | |
| SplitButton | mount | 2836 | 2815 | 5000 | |
| Stack | mount | 857 | 872 | 5000 | |
| StackWithIntrinsicChildren | mount | 2335 | 2333 | 5000 | |
| StackWithTextChildren | mount | 5045 | 5036 | 5000 | |
| SwatchColorPicker | mount | 9525 | 9452 | 5000 | |
| TagPicker | mount | 2342 | 2335 | 5000 | |
| TeachingBubble | mount | 76361 | 76255 | 5000 | |
| Text | mount | 822 | 820 | 5000 | |
| TextField | mount | 1544 | 1538 | 5000 | |
| ThemeProvider | mount | 1448 | 1442 | 5000 | |
| ThemeProvider | virtual-rerender | 1145 | 1141 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1983 | 2011 | 5000 | |
| Toggle | mount | 1131 | 1137 | 5000 | |
| buttonNative | mount | 538 | 536 | 5000 |
ling1726
approved these changes
Oct 27, 2022
spmonahan
approved these changes
Oct 27, 2022
khmakoto
approved these changes
Oct 27, 2022
sopranopillow
approved these changes
Oct 28, 2022
Hotell
approved these changes
Nov 1, 2022
layershifter
force-pushed
the
chore/bump-griffel4
branch
from
296c6bd to
46a6739
Compare
layershifter
force-pushed
the
chore/bump-griffel4
branch
from
46a6739 to
59b7f9c
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 2, 2022
* master: (23 commits) fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385) applying package updates feat: Implement child render function for DataGrid rows (microsoft#25476) fix(useTable): sort should adapt to enhanced row types (microsoft#25487) applying package updates feat: positioning should happen out of React lifecycle (microsoft#25456) applying package updates chore(react-link): migrate to new package structure (microsoft#25471) chore(react-input): migrate to new package structure (microsoft#25469) fix glob pattern for syncpack (microsoft#25465) chore(react-label): migrate to new package structure (microsoft#25470) chore: bump Griffel to latest (microsoft#25412) chore: add few small toolbar improvements (microsoft#25468) docs: fix small typos (microsoft#25464) chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466) feat: v0 menu style migration from v9 (microsoft#25012) applying package updates Update List to render children on first render() call (microsoft#25331) Scaffold react-skeleton package (microsoft#25435) fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
Bumps Griffel to latest to have:
That unblock #25216.