Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' #25437

Merged

Conversation

sopranopillow
Copy link
Contributor

Current Behavior

Some urls for crossplatform use #<page>/crossplatform/... instead of #<page>/cross/... which breaks our hash routing. See issue below for more information.

New Behavior

All crossplatform urls now use cross instead of crossplatform which fixes our routing.

Related Issue(s)

Fixes #23213

@sopranopillow sopranopillow added Area: Website Fluent UI react (v8) Issues about @fluentui/react (v8) labels Oct 30, 2022
@sopranopillow sopranopillow self-assigned this Oct 30, 2022
@sopranopillow sopranopillow marked this pull request as ready for review October 30, 2022 03:04
@sopranopillow sopranopillow requested a review from a team as a code owner October 30, 2022 03:04
@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against aa6aca3508e3578b5182d82be8173a42eb17d906

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5386d68:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 30, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: aa6aca3508e3578b5182d82be8173a42eb17d906 (build)

@sopranopillow sopranopillow merged commit 7a7ed4b into microsoft:master Oct 31, 2022
@sopranopillow sopranopillow deleted the public-docsite/related-links branch October 31, 2022 19:04
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Nov 2, 2022
* master: (23 commits)
  fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385)
  applying package updates
  feat: Implement child render function for DataGrid rows (microsoft#25476)
  fix(useTable): sort should adapt to enhanced row types (microsoft#25487)
  applying package updates
  feat: positioning should happen out of React lifecycle (microsoft#25456)
  applying package updates
  chore(react-link): migrate to new package structure (microsoft#25471)
  chore(react-input): migrate to new package structure (microsoft#25469)
  fix glob pattern for syncpack (microsoft#25465)
  chore(react-label): migrate to new package structure (microsoft#25470)
  chore: bump Griffel to latest (microsoft#25412)
  chore: add few small toolbar improvements (microsoft#25468)
  docs: fix small typos (microsoft#25464)
  chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466)
  feat: v0 menu style migration from v9 (microsoft#25012)
  applying package updates
  Update List to render children on first render() call (microsoft#25331)
  Scaffold react-skeleton package (microsoft#25435)
  fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

website bugs reporting
4 participants