fix(docsite-v9): move theme picker #25385
Conversation
📊 Bundle size report🤖 This report was generated against f6f3e4b27f850577890dce15000bf8d4dedc4381 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: f6f3e4b27f850577890dce15000bf8d4dedc4381 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c2356ab:
|
… visible on embedded pages
tudorpopams
force-pushed
the
fix/storybook-theme-changer-position
branch
from
c8b9e9d to
c2356ab
Compare
|
I don't think it's worth blocking right now, but maybe add a backlog item to come back and improve the layout a bit? It'd be nice to not have everything so stacked. Moving the Button out to the right will take a bit of work (especially to make sure it works over viewports and title lengths).
Or maybe make it part of the sidebar (though again need to solve for smaller screen where the sidebar isn't present)
|
* master: (23 commits) fix(docsite-v9): move theme picker under component title so it can be visible on embedded pages (microsoft#25385) applying package updates feat: Implement child render function for DataGrid rows (microsoft#25476) fix(useTable): sort should adapt to enhanced row types (microsoft#25487) applying package updates feat: positioning should happen out of React lifecycle (microsoft#25456) applying package updates chore(react-link): migrate to new package structure (microsoft#25471) chore(react-input): migrate to new package structure (microsoft#25469) fix glob pattern for syncpack (microsoft#25465) chore(react-label): migrate to new package structure (microsoft#25470) chore: bump Griffel to latest (microsoft#25412) chore: add few small toolbar improvements (microsoft#25468) docs: fix small typos (microsoft#25464) chore: fix dependencies in @fluentui/react-toolbar (microsoft#25466) feat: v0 menu style migration from v9 (microsoft#25012) applying package updates Update List to render children on first render() call (microsoft#25331) Scaffold react-skeleton package (microsoft#25435) fix(public-docsite): Changing crossplatform urls to use 'cross' instead of 'crossplatform' (microsoft#25437) ...
… visible on embedded pages (microsoft#25385)
… visible on embedded pages (microsoft#25385)
Current Behavior
The theme picker is currently positioned on the top bar of the docsite making it unusable for embedded pages.
New Behavior
By moving the theme picker under each component's title bar, we will have access to it both on iframes and normal docsite.