chore: Expand scope of dependency mismatch generator #24880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands the scope of the dependency mismatch generator to align dependencies in the repo even if they are not v9. The exception here is northstar/v0, since it has a dependency on a former major of a v8 dependency
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 07bcf33:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bc07875872cd357617adf8a6dcf5a46323737406 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1264 | 1272 | 5000 | |
| Button | mount | 931 | 938 | 5000 | |
| FluentProvider | mount | 1476 | 1490 | 5000 | |
| FluentProviderWithTheme | mount | 577 | 581 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 545 | 547 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 575 | 582 | 10 | |
| MakeStyles | mount | 1962 | 1940 | 50000 | |
| SpinButton | mount | 2368 | 2365 | 5000 |
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AttachmentMinimalPerf.default | 135 | 125 | 1.08:1 |
| ListCommonPerf.default | 535 | 500 | 1.07:1 |
| SegmentMinimalPerf.default | 312 | 292 | 1.07:1 |
| PortalMinimalPerf.default | 145 | 138 | 1.05:1 |
| AvatarMinimalPerf.default | 171 | 164 | 1.04:1 |
| BoxMinimalPerf.default | 307 | 295 | 1.04:1 |
| LabelMinimalPerf.default | 351 | 337 | 1.04:1 |
| IconMinimalPerf.default | 577 | 554 | 1.04:1 |
| ButtonMinimalPerf.default | 140 | 136 | 1.03:1 |
| FormMinimalPerf.default | 326 | 318 | 1.03:1 |
| ListNestedPerf.default | 482 | 466 | 1.03:1 |
| PopupMinimalPerf.default | 564 | 550 | 1.03:1 |
| TableMinimalPerf.default | 369 | 359 | 1.03:1 |
| AttachmentSlotsPerf.default | 885 | 871 | 1.02:1 |
| CardMinimalPerf.default | 464 | 457 | 1.02:1 |
| HeaderMinimalPerf.default | 324 | 319 | 1.02:1 |
| ListMinimalPerf.default | 460 | 450 | 1.02:1 |
| MenuMinimalPerf.default | 734 | 719 | 1.02:1 |
| TextAreaMinimalPerf.default | 412 | 402 | 1.02:1 |
| TreeWith60ListItems.default | 128 | 125 | 1.02:1 |
| ButtonSlotsPerf.default | 429 | 423 | 1.01:1 |
| ChatDuplicateMessagesPerf.default | 235 | 232 | 1.01:1 |
| ChatMinimalPerf.default | 643 | 639 | 1.01:1 |
| DropdownMinimalPerf.default | 2172 | 2160 | 1.01:1 |
| EmbedMinimalPerf.default | 2646 | 2621 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 976 | 971 | 1.01:1 |
| ListWith60ListItems.default | 512 | 509 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1351 | 1341 | 1.01:1 |
| RadioGroupMinimalPerf.default | 391 | 386 | 1.01:1 |
| RefMinimalPerf.default | 189 | 188 | 1.01:1 |
| SliderMinimalPerf.default | 1240 | 1224 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3271 | 3242 | 1.01:1 |
| TableManyItemsPerf.default | 1576 | 1553 | 1.01:1 |
| TextMinimalPerf.default | 304 | 300 | 1.01:1 |
| ToolbarMinimalPerf.default | 791 | 787 | 1.01:1 |
| AnimationMinimalPerf.default | 471 | 469 | 1:1 |
| CheckboxMinimalPerf.default | 1524 | 1529 | 1:1 |
| DatepickerMinimalPerf.default | 4640 | 4648 | 1:1 |
| DividerMinimalPerf.default | 310 | 311 | 1:1 |
| DropdownManyItemsPerf.default | 540 | 542 | 1:1 |
| HeaderSlotsPerf.default | 683 | 680 | 1:1 |
| InputMinimalPerf.default | 851 | 850 | 1:1 |
| LayoutMinimalPerf.default | 308 | 308 | 1:1 |
| RosterPerf.default | 1724 | 1719 | 1:1 |
| CustomToolbarPrototype.default | 2162 | 2159 | 1:1 |
| TooltipMinimalPerf.default | 1874 | 1870 | 1:1 |
| TreeMinimalPerf.default | 705 | 707 | 1:1 |
| VideoMinimalPerf.default | 632 | 630 | 1:1 |
| AccordionMinimalPerf.default | 125 | 126 | 0.99:1 |
| ButtonOverridesMissPerf.default | 1012 | 1022 | 0.99:1 |
| DialogMinimalPerf.default | 684 | 688 | 0.99:1 |
| FlexMinimalPerf.default | 247 | 250 | 0.99:1 |
| ReactionMinimalPerf.default | 323 | 327 | 0.99:1 |
| SkeletonMinimalPerf.default | 300 | 304 | 0.99:1 |
| StatusMinimalPerf.default | 594 | 601 | 0.99:1 |
| CarouselMinimalPerf.default | 342 | 354 | 0.97:1 |
| LoaderMinimalPerf.default | 504 | 518 | 0.97:1 |
| ProviderMergeThemesPerf.default | 973 | 1004 | 0.97:1 |
| ProviderMinimalPerf.default | 314 | 324 | 0.97:1 |
| AlertMinimalPerf.default | 216 | 224 | 0.96:1 |
| ChatWithPopoverPerf.default | 290 | 302 | 0.96:1 |
| GridMinimalPerf.default | 293 | 307 | 0.95:1 |
| ImageMinimalPerf.default | 339 | 355 | 0.95:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 1191 | 1187 | 5000 | |
| Breadcrumb | mount | 2829 | 2802 | 1000 | |
| Checkbox | mount | 2672 | 2647 | 5000 | |
| CheckboxBase | mount | 2359 | 2371 | 5000 | |
| ChoiceGroup | mount | 4205 | 4258 | 5000 | |
| ComboBox | mount | 1178 | 1187 | 1000 | |
| CommandBar | mount | 9270 | 9240 | 1000 | |
| ContextualMenu | mount | 10185 | 10178 | 1000 | |
| DefaultButton | mount | 1362 | 1349 | 5000 | |
| DetailsRow | mount | 3355 | 3366 | 5000 | |
| DetailsRowFast | mount | 3385 | 3378 | 5000 | |
| DetailsRowNoStyles | mount | 3216 | 3215 | 5000 | |
| Dialog | mount | 2934 | 2954 | 1000 | |
| DocumentCardTitle | mount | 583 | 571 | 1000 | |
| Dropdown | mount | 3124 | 3196 | 5000 | |
| FocusTrapZone | mount | 1990 | 1979 | 5000 | |
| FocusZone | mount | 1968 | 1937 | 5000 | |
| GroupedList | mount | 48162 | 52945 | 2 | |
| GroupedList | virtual-rerender | 23347 | 22994 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 81594 | 84134 | 2 | |
| GroupedListV2 | mount | 562 | 559 | 2 | |
| GroupedListV2 | virtual-rerender | 530 | 529 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 563 | 561 | 2 | |
| IconButton | mount | 1790 | 1786 | 5000 | |
| Label | mount | 740 | 759 | 5000 | |
| Layer | mount | 4112 | 4121 | 5000 | |
| Link | mount | 842 | 863 | 5000 | |
| MenuButton | mount | 1611 | 1624 | 5000 | |
| MessageBar | mount | 2310 | 2341 | 5000 | |
| Nav | mount | 3077 | 3057 | 1000 | |
| OverflowSet | mount | 1404 | 1423 | 5000 | |
| Panel | mount | 2455 | 2480 | 1000 | |
| Persona | mount | 1258 | 1254 | 1000 | |
| Pivot | mount | 1513 | 1507 | 1000 | |
| PrimaryButton | mount | 1488 | 1499 | 5000 | |
| Rating | mount | 7021 | 7003 | 5000 | |
| SearchBox | mount | 1495 | 1486 | 5000 | |
| Shimmer | mount | 2904 | 2923 | 5000 | |
| Slider | mount | 2103 | 2110 | 5000 | |
| SpinButton | mount | 4277 | 4282 | 5000 | |
| Spinner | mount | 831 | 843 | 5000 | |
| SplitButton | mount | 2812 | 2820 | 5000 | |
| Stack | mount | 890 | 897 | 5000 | |
| StackWithIntrinsicChildren | mount | 2258 | 2247 | 5000 | |
| StackWithTextChildren | mount | 4938 | 4945 | 5000 | |
| SwatchColorPicker | mount | 9491 | 9598 | 5000 | |
| TagPicker | mount | 2459 | 2351 | 5000 | |
| TeachingBubble | mount | 74912 | 74812 | 5000 | |
| Text | mount | 820 | 823 | 5000 | |
| TextField | mount | 1553 | 1538 | 5000 | |
| ThemeProvider | mount | 1458 | 1446 | 5000 | |
| ThemeProvider | virtual-rerender | 1153 | 1143 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2015 | 1999 | 5000 | |
| Toggle | mount | 1137 | 1130 | 5000 | |
| buttonNative | mount | 531 | 536 | 5000 |
Hotell
reviewed
Sep 21, 2022
| }, | ||
| tags: string[] = [], |
There was a problem hiding this comment.
chore: can we have this only as options (named arguments), positional arguments don't scale and provide bad DX on call site
workspace.json
Outdated
| @@ -10,12 +10,14 @@ | |||
| "@fluentui/ability-attributes": { | |||
| "root": "packages/fluentui/ability-attributes", | |||
| "projectType": "library", | |||
| "implicitDependencies": [] | |||
| "implicitDependencies": [], | |||
| "tags": ["northstar"] | |||
There was a problem hiding this comment.
we should be unify tags declaration. atm we use vNext for v9, v8 for react https://github.com/microsoft/fluentui/pull/22604/files#diff-8615bf67663730c68237b51aa01c74d409e3ebfa0ddb23cde704c9a2e97779fd
if we wanna go with package name we should go with:
react
react-components
react-northstar
althought the react tag for v8 is missleading without additional context(docs)
thoughts?
There was a problem hiding this comment.
I don't mind, just pick a convention and go with it
There was a problem hiding this comment.
let's go with package names, it's much more realistic. I'll update to react-norhtstar in this PR and we can update the other packages in other PRs
Hotell
approved these changes
Sep 21, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
* chore: Expand scope of dependency mismatch generator Expands the scope of the dependency mismatch generator to align dependencies in the repo even if they are not v9. The exception here is northstar/v0, since it has a dependency on a former major of a v8 dependency * update unit tests * use react-northstar instead of northstar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands the scope of the dependency mismatch generator to align dependencies in the repo even if they are not v9.
The exception here is northstar/v0, since it has a dependency on a former major of a v8 dependency
Partially addresses: #23147