Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-overflow): update package scaffold #24926

Conversation

bsunderhus
Copy link
Contributor

Migrates react-overflow converged package to new DX by using the migration command:

yarn nx workspace-generator migrate-converged-pkg --name='@fluentui/react-overflow'

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.689 kB
52.37 kB
react-components
react-components: FluentProvider & webLightTheme
33.394 kB
11.007 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
🤖 This report was generated against 6e3d534c4328df8a15f163c0a35241657e7d5a4e

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0484029:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Sep 23, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6e3d534c4328df8a15f163c0a35241657e7d5a4e (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1538 1523 5000
Button mount 1111 1115 5000
FluentProvider mount 1901 1892 5000
FluentProviderWithTheme mount 741 745 10
FluentProviderWithTheme virtual-rerender 709 706 10
FluentProviderWithTheme virtual-rerender-with-unmount 741 737 10
MakeStyles mount 2231 2272 50000
SpinButton mount 2977 2969 5000

@bsunderhus bsunderhus marked this pull request as ready for review September 23, 2022 13:13
@bsunderhus bsunderhus requested a review from a team as a code owner September 23, 2022 13:13
@bsunderhus bsunderhus enabled auto-merge (squash) September 23, 2022 13:58
@bsunderhus bsunderhus merged commit fa59098 into microsoft:master Sep 23, 2022
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 24, 2022
* master: (29 commits)
  chore(react-tooltip): update package scaffold (microsoft#24927)
  chore(react-popover): update package scaffold (microsoft#24925)
  chore(react-overflow): update package scaffold (microsoft#24926)
  chore(react-menu): update package scaffold (microsoft#24924)
  applying package updates
  chore: Bump workspace-tools to 0.27.0 (microsoft#24914)
  fix: Make Menu openOnHover prop work again (microsoft#24899)
  stress test: convert cli scripts to typescript (microsoft#24915)
  update package manifest to only include v8 controls (microsoft#24839)
  Stress Test: add random tree (microsoft#24896)
  chore: Expand scope of dependency mismatch generator (microsoft#24880)
  chore: run dependency mismatch generator in release pipeline (microsoft#24881)
  chore: scaffolds react-trigger package (microsoft#24887)
  applying package updates
  chore: a11y docs structure update (microsoft#24871)
  feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693)
  fix: Set github user in nightly release pipeline (microsoft#24850)
  chore(react-aria): restructure folder organization (microsoft#24884)
  ci(github): fix invalid json string in issues.yml v2 (microsoft#24886)
  Add react-components/unstable to tsconfig aliases (microsoft#24878)
  ...
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants