fix: Make Menu openOnHover prop work again #24899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report
Unchanged fixtures
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0baf43c:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 3f105cca41d951f161edbb90be116565311e72d1 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1305 | 1320 | 5000 | |
| Button | mount | 953 | 949 | 5000 | |
| FluentProvider | mount | 1691 | 1566 | 5000 | |
| FluentProviderWithTheme | mount | 643 | 634 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 589 | 593 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 636 | 629 | 10 | |
| MakeStyles | mount | 1897 | 1895 | 50000 | |
| SpinButton | mount | 2550 | 2575 | 5000 |
|
Nice catch, and thx for the fix @behowell . Do you mind adding a cypress e2e test for this ? I'm quite surprised no test failed during the original refactor 😱😱 |
bsunderhus
reviewed
Sep 22, 2022
There was a problem hiding this comment.
LGMT! thx for the PR @behowell, definitely didn't see that regression meanwhile doing the refactoring! Adding an e2e test case would be ideal here though!
|
We caught this in Loop with a Jest JSDOM test, so that would also work (I don't know what's standard for your repo, however) |
|
@ling1726 @bsunderhus I've added a cypress e2e test. |
bsunderhus
approved these changes
Sep 23, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 24, 2022
* master: (29 commits) chore(react-tooltip): update package scaffold (microsoft#24927) chore(react-popover): update package scaffold (microsoft#24925) chore(react-overflow): update package scaffold (microsoft#24926) chore(react-menu): update package scaffold (microsoft#24924) applying package updates chore: Bump workspace-tools to 0.27.0 (microsoft#24914) fix: Make Menu openOnHover prop work again (microsoft#24899) stress test: convert cli scripts to typescript (microsoft#24915) update package manifest to only include v8 controls (microsoft#24839) Stress Test: add random tree (microsoft#24896) chore: Expand scope of dependency mismatch generator (microsoft#24880) chore: run dependency mismatch generator in release pipeline (microsoft#24881) chore: scaffolds react-trigger package (microsoft#24887) applying package updates chore: a11y docs structure update (microsoft#24871) feat: add popupProps to Modal component to allow override internal Popup props (microsoft#24693) fix: Set github user in nightly release pipeline (microsoft#24850) chore(react-aria): restructure folder organization (microsoft#24884) ci(github): fix invalid json string in issues.yml v2 (microsoft#24886) Add react-components/unstable to tsconfig aliases (microsoft#24878) ...
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Use the openOnHover prop in Menu again. It defaults to isSubmenu but can be overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Regression from the refactoring in PR #24562, Menu no longer respects the
openOnHoverprop.New Behavior
Use the
openOnHoverprop in Menu again. It defaults toisSubmenubut can be overridden.Related Issue(s)