Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Beachball tries to bump a package from a caret peerDependency #23147

Closed
2 tasks done
spmonahan opened this issue May 23, 2022 · 5 comments
Closed
2 tasks done

[Bug]: Beachball tries to bump a package from a caret peerDependency #23147

spmonahan opened this issue May 23, 2022 · 5 comments
Assignees
Labels

Comments

@spmonahan
Copy link
Contributor

Library

React Components / v9 (@fluentui/react-components)

System Info

This happened in the Azure Pipeline release build.

Are you reporting Accessibility issue?

no

Reproduction

N/A

Bug Description

Actual Behavior

When attempting to release a package that has a caret dependency the release pipeline will "bump" to the same, already released version of a package, causing the release to fail.

Expected Behavior

A caret dependency change for a package should not cause a release to fail. Either the package should be bumped to a new release version or it should be skipped.

Notes

This happened in the react-conformance-griffel package where the peerDep was set to ^0.13.0 while the devDep was set to *.

Link to package.json for the commit

Logs

The issue first appeared in a release build but is reproducible locally.
Build: https://uifabric.visualstudio.com/UI%20Fabric/_build/results?buildId=250403&view=logs&j=8d802004-fbbb-5f17-b73e-f23de0c1dec8&t=fb65810a-a7a9-58a0-61f9-7163cb0bcc0b&l=187

Requested priority

High

Products/sites affected

@fluentui/react-components, possible @fluentui/react and northstar as well

Are you willing to submit a PR to fix?

yes

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@spmonahan
Copy link
Contributor Author

Possibly related issue in Beachball repo: microsoft/beachball#583

@spmonahan
Copy link
Contributor Author

Related issue: marwan38@ada38f4

@ling1726
Copy link
Member

This happens because @fluentui/react-conformance-griffel depends on @fluentui/react-conformance. They are released on different cycles.

react-conformance is released during the v8 cycle (daily) which does not bump react-conformance-griffel.

  1. react-conformance is 1.0.0, react-conformance-griffel depends on 1.0.0
  2. release react-conformance to 1.1.0
  3. release react-conformance-griffel
  4. ERROR: beachball generates a change for react-conformance-griffel because react-conformance version changed
  5. release failed

@msft-fluent-ui-bot msft-fluent-ui-bot added the Resolution: Soft Close Soft closing inactive issues over a certain period label Apr 21, 2023
@msft-fluent-ui-bot
Copy link
Collaborator

Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes.

Still require assistance? Please, create a new issue with up-to date details.

@Hotell
Copy link
Contributor

Hotell commented May 30, 2023

we haven't run into this for quite some time. closing

@Hotell Hotell closed this as completed May 30, 2023
@microsoft microsoft locked as resolved and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

7 participants