-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug]: Beachball tries to bump a package from a caret peerDependency #23147
Comments
Possibly related issue in Beachball repo: microsoft/beachball#583 |
Related issue: marwan38@ada38f4 |
This happens because @fluentui/react-conformance-griffel depends on @fluentui/react-conformance. They are released on different cycles. react-conformance is released during the v8 cycle (daily) which does not bump react-conformance-griffel.
|
Because this issue has not had activity for over 180 days, we're automatically closing it for house-keeping purposes. Still require assistance? Please, create a new issue with up-to date details. |
we haven't run into this for quite some time. closing |
Library
React Components / v9 (@fluentui/react-components)
System Info
This happened in the Azure Pipeline release build.
Are you reporting Accessibility issue?
no
Reproduction
N/A
Bug Description
Actual Behavior
When attempting to release a package that has a caret dependency the release pipeline will "bump" to the same, already released version of a package, causing the release to fail.
Expected Behavior
A caret dependency change for a package should not cause a release to fail. Either the package should be bumped to a new release version or it should be skipped.
Notes
This happened in the
react-conformance-griffel
package where the peerDep was set to^0.13.0
while the devDep was set to*
.Link to package.json for the commit
Logs
Requested priority
High
Products/sites affected
@fluentui/react-components, possible @fluentui/react and northstar as well
Are you willing to submit a PR to fix?
yes
Validations
The text was updated successfully, but these errors were encountered: