[FtpUploadV2] Resolve dependabot alert about shelljs #15881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested these changes manually by running canary on windows and debian. Everything works as expected. |
…t' of https://github.com/microsoft/azure-pipelines-tasks into users/DaniilShmelev/FtpUploadV2-resolve-dependabot-alert
DaniilShmelev
commented
Feb 9, 2022
DaniilShmelev
commented
Feb 17, 2022
|
LGTM |
DaniilShmelev
commented
Feb 21, 2022
anatolybolshakov
approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Approved from behalf of @DaniilShmelev (since I did last changes, but author can't approve his own PRs)
aasim
pushed a commit
that referenced
this pull request
Mar 8, 2022
* fix dependencies * fix build build error are caused by tasklib 3.x return types change from "<type>" to "<type> | undefined" functionally, these method calls should be identical * bump task version * Add simple unit tests to check getting input parameters and start of task * Delete debug * Fix EOL * Updated task version to 201 * Added test for successful execution Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]> Co-authored-by: Tatyana Kostromskaya <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Anatoly Bolshakov <[email protected]>
aasim
added a commit
that referenced
this pull request
Mar 8, 2022
* Fixed casing for packaging api data * Updated task version * [Maven tasks] Bump the codecoverage-tools package at the dependencies (#15928) * Update cc-tools package for MavenV2 task * Update cc-tools package for MaveV3 task * Disabled percent encoding (#15931) * Update npmauth to handle retries cleanly (#15914) * Update npmauth.ts * Update task.json * Update task.loc.json * Update npmauth.ts * RED Co-authored-by: Your Name <[email protected]> * Updated Helm download Url (#15821) * updated helm download url * bumped task vesrions required for this change * bumped task versions * [FtpUploadV2] Resolve dependabot alert about shelljs (#15881) * fix dependencies * fix build build error are caused by tasklib 3.x return types change from "<type>" to "<type> | undefined" functionally, these method calls should be identical * bump task version * Add simple unit tests to check getting input parameters and start of task * Delete debug * Fix EOL * Updated task version to 201 * Added test for successful execution Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]> Co-authored-by: Tatyana Kostromskaya <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Anatoly Bolshakov <[email protected]> * Fix README.md section on installing Invoke-SqlCommand on an agent (#15693) * Add another way of installing Invoke-SqlCommand. * Fix dead link. Co-authored-by: Kim Jämiä <[email protected]> Co-authored-by: Philipson Joseph V <[email protected]> * updating the azure-pipelines-tasks-azure-arm-rest-v2 to 2.198.2 (#15935) * version update of common module * version update Co-authored-by: rajnish-byte <[email protected]> * Fix shelljs vulnerability for tasks (#15972) * bump shelljs for ArchiveFilesV2 * bump shelljs for BashV3 * bump shelljs for CMakeV1 * bump shelljs for CocoaPodsV0 * bump affected tasks versions * 15646 - Machine Names required", but should not be required, and machine names being prepended to destination folder #15646 (#15870) * Making Machines,AdminLogin,Password as Mandatory * Making Machines,Admin Login and Password required fields * fix no wait result bug (#15957) * fix no wait result bug * bump version Co-authored-by: Anatoly Bolshakov <[email protected]> Co-authored-by: Nikita Ezzhev <[email protected]> * [UsePythonV0] Download python from registry (#15820) * download python from registry if absent in cache * add unit test * fixes & debug messages * fix manifest branch name * fix debug message for python archive file name * remove unneeded function * fix unit tests failing on unix * only check os version once * add unit test for ubuntu version lookup * adjust error messages * add input to allow unstable versions * fix ubuntu test * add test for unstable version download * add comments * adjust comments * select arch based on input * extract interfaces into separate file * make allowUnstable optional * add a separate debug message for downloading * explain what the registry is more clearly * bump task version due to a new sprint * fix allowUnstable default value * format osutil to unify code style * Updated version Co-authored-by: Aasim Malladi <[email protected]> Co-authored-by: Konstantin Tyukalov <[email protected]> Co-authored-by: Anatoly Bolshakov <[email protected]> Co-authored-by: Marcin Strzyz <[email protected]> Co-authored-by: Your Name <[email protected]> Co-authored-by: rajnish-byte <[email protected]> Co-authored-by: Daniil Shmelev <[email protected]> Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]> Co-authored-by: Tatyana Kostromskaya <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Denis Tikhomirov <[email protected]> Co-authored-by: Kim Jämiä <[email protected]> Co-authored-by: Kim Jämiä <[email protected]> Co-authored-by: Philipson Joseph V <[email protected]> Co-authored-by: v-hinti <[email protected]> Co-authored-by: v-nagarajku <[email protected]> Co-authored-by: Ruoyu Wang <[email protected]> Co-authored-by: Nikita Ezzhev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: FtpUploadV2
Description: Bumped tasklib to 3.x
Documentation changes required: No
Added unit tests: No
Attached related issue: No
Checklist: