Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Helm download Url #15821

Merged
merged 5 commits into from
Feb 18, 2022
Merged

Updated Helm download Url #15821

merged 5 commits into from
Feb 18, 2022

Conversation

rajnish-byte
Copy link
Contributor

@rajnish-byte rajnish-byte commented Jan 25, 2022

Task name: HelmInstallerV0/V1

Description: Updated the helm download url as the previous link was stale and could be used to send malicious payload.

Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N

Attached related issue: (Y/N)

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@mmrazik
Copy link
Collaborator

mmrazik commented Feb 9, 2022

One comment here, though -- make sure we are downloading the versions which are available on get.helm. It would be bad if we are pinned to some old helm version which is not available in the new place and our tasks will be failing.

@anatolybolshakov
Copy link
Contributor

Please also make sure that task version is bumped (you can find more info here) - otherwise task won't be updated.

@ghost
Copy link

ghost commented Feb 17, 2022

CLA assistant check
All CLA requirements met.

@rajnish-byte rajnish-byte merged commit 81594a9 into master Feb 18, 2022
aasim pushed a commit that referenced this pull request Mar 8, 2022
* updated helm download url

* bumped task vesrions required for this change

* bumped task versions
aasim added a commit that referenced this pull request Mar 8, 2022
* Fixed casing for packaging api data

* Updated task version

* [Maven tasks] Bump the codecoverage-tools package at the dependencies (#15928)

* Update cc-tools package for MavenV2 task

* Update cc-tools package for MaveV3 task

* Disabled percent encoding (#15931)

* Update npmauth to handle retries cleanly (#15914)

* Update npmauth.ts

* Update task.json

* Update task.loc.json

* Update npmauth.ts

* RED

Co-authored-by: Your Name <[email protected]>

* Updated Helm download Url (#15821)

* updated helm download url

* bumped task vesrions required for this change

* bumped task versions

* [FtpUploadV2] Resolve dependabot alert about shelljs (#15881)

* fix dependencies

* fix build

build error are caused by tasklib 3.x return types change from "<type>" to "<type> | undefined"
functionally, these method calls should be identical

* bump task version

* Add simple unit tests to check getting input parameters and start of task

* Delete debug

* Fix EOL

* Updated task version to 201

* Added test for successful execution

Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]>
Co-authored-by: Tatyana Kostromskaya <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Anatoly Bolshakov <[email protected]>

* Fix README.md section on installing Invoke-SqlCommand on an agent (#15693)

* Add another way of installing Invoke-SqlCommand.
* Fix dead link.

Co-authored-by: Kim Jämiä <[email protected]>
Co-authored-by: Philipson Joseph V <[email protected]>

* updating  the azure-pipelines-tasks-azure-arm-rest-v2 to 2.198.2  (#15935)

* version update of common module

* version update

Co-authored-by: rajnish-byte <[email protected]>

* Fix shelljs vulnerability for tasks (#15972)

* bump shelljs for ArchiveFilesV2

* bump shelljs for BashV3

* bump shelljs for CMakeV1

* bump shelljs for CocoaPodsV0

* bump affected tasks versions

* 15646 - Machine Names required", but should not be required, and machine names being prepended to destination folder #15646 (#15870)

* Making Machines,AdminLogin,Password as Mandatory

* Making Machines,Admin Login and Password required fields

* fix no wait result bug (#15957)

* fix no wait result bug

* bump version

Co-authored-by: Anatoly Bolshakov <[email protected]>
Co-authored-by: Nikita Ezzhev <[email protected]>

* [UsePythonV0] Download python from registry (#15820)

* download python from registry if absent in cache

* add unit test

* fixes & debug messages

* fix manifest branch name

* fix debug message for python archive file name

* remove unneeded function

* fix unit tests failing on unix

* only check os version once

* add unit test for ubuntu version lookup

* adjust error messages

* add input to allow unstable versions

* fix ubuntu test

* add test for unstable version download

* add comments

* adjust comments

* select arch based on input

* extract interfaces into separate file

* make allowUnstable optional

* add a separate debug message for downloading

* explain what the registry is more clearly

* bump task version due to a new sprint

* fix allowUnstable default value

* format osutil to unify code style

* Updated version

Co-authored-by: Aasim Malladi <[email protected]>
Co-authored-by: Konstantin Tyukalov <[email protected]>
Co-authored-by: Anatoly Bolshakov <[email protected]>
Co-authored-by: Marcin Strzyz <[email protected]>
Co-authored-by: Your Name <[email protected]>
Co-authored-by: rajnish-byte <[email protected]>
Co-authored-by: Daniil Shmelev <[email protected]>
Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]>
Co-authored-by: Tatyana Kostromskaya <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Kim Jämiä <[email protected]>
Co-authored-by: Kim Jämiä <[email protected]>
Co-authored-by: Philipson Joseph V <[email protected]>
Co-authored-by: v-hinti <[email protected]>
Co-authored-by: v-nagarajku <[email protected]>
Co-authored-by: Ruoyu Wang <[email protected]>
Co-authored-by: Nikita Ezzhev <[email protected]>
@starkmsu starkmsu deleted the rajnish-byte/downloadUrl branch July 14, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants