Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed casing for packaging api data #15877

Merged
merged 18 commits into from
Mar 8, 2022
Merged

Conversation

aasim
Copy link
Member

@aasim aasim commented Feb 4, 2022

Task name: DownloadPackageV1

Description: Fixed casing for when calling packaging apis

Documentation changes required: (Y/N) N

Added unit tests: (Y/N) N

Attached related issue: (Y/N) https://dev.azure.com/mseng/AzureDevOps/_workitems/edit/1912488/

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@aasim aasim requested a review from phil-hodgson as a code owner February 4, 2022 00:41
@phil-hodgson
Copy link
Member

Waiting for some unit tests to get added to prevent regressions

KonstantinTyukalov and others added 13 commits March 8, 2022 22:42
…#15928)

* Update cc-tools package for MavenV2 task

* Update cc-tools package for MaveV3 task
* Update npmauth.ts

* Update task.json

* Update task.loc.json

* Update npmauth.ts

* RED

Co-authored-by: Your Name <[email protected]>
* updated helm download url

* bumped task vesrions required for this change

* bumped task versions
* fix dependencies

* fix build

build error are caused by tasklib 3.x return types change from "<type>" to "<type> | undefined"
functionally, these method calls should be identical

* bump task version

* Add simple unit tests to check getting input parameters and start of task

* Delete debug

* Fix EOL

* Updated task version to 201

* Added test for successful execution

Co-authored-by: Tatyana Kostromskaya (Akvelon) <[email protected]>
Co-authored-by: Tatyana Kostromskaya <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Denis Tikhomirov <[email protected]>
Co-authored-by: Anatoly Bolshakov <[email protected]>
…5693)

* Add another way of installing Invoke-SqlCommand.
* Fix dead link.

Co-authored-by: Kim Jämiä <[email protected]>
Co-authored-by: Philipson Joseph V <[email protected]>
* version update of common module

* version update

Co-authored-by: rajnish-byte <[email protected]>
* bump shelljs for ArchiveFilesV2

* bump shelljs for BashV3

* bump shelljs for CMakeV1

* bump shelljs for CocoaPodsV0

* bump affected tasks versions
…ine names being prepended to destination folder #15646 (#15870)

* Making Machines,AdminLogin,Password as Mandatory

* Making Machines,Admin Login and Password required fields
* fix no wait result bug

* bump version

Co-authored-by: Anatoly Bolshakov <[email protected]>
Co-authored-by: Nikita Ezzhev <[email protected]>
* download python from registry if absent in cache

* add unit test

* fixes & debug messages

* fix manifest branch name

* fix debug message for python archive file name

* remove unneeded function

* fix unit tests failing on unix

* only check os version once

* add unit test for ubuntu version lookup

* adjust error messages

* add input to allow unstable versions

* fix ubuntu test

* add test for unstable version download

* add comments

* adjust comments

* select arch based on input

* extract interfaces into separate file

* make allowUnstable optional

* add a separate debug message for downloading

* explain what the registry is more clearly

* bump task version due to a new sprint

* fix allowUnstable default value

* format osutil to unify code style
@edgarrs
Copy link
Contributor

edgarrs commented Mar 8, 2022

@aasim, please open a new issue to add missing tests to avoid further regressions

@aasim
Copy link
Member Author

aasim commented Mar 8, 2022

@aasim aasim merged commit 74af506 into master Mar 8, 2022
aasim pushed a commit that referenced this pull request Apr 13, 2022
@aasim aasim mentioned this pull request Apr 13, 2022
2 tasks
aasim added a commit that referenced this pull request Apr 13, 2022
aasim added a commit that referenced this pull request Apr 13, 2022
mmrazik pushed a commit that referenced this pull request Apr 14, 2022
* Revert changes from PR #15877. (#16145)

Co-authored-by: Aasim Malladi <[email protected]>

* Added ws

* Removed ws

Co-authored-by: Aasim Malladi <[email protected]>
aasim added a commit that referenced this pull request Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.