"Machine Names required", but should not be required, and machine names being prepended to destination folder

[lrpinto]

Bug

Type: Error: "Machine Names required", but should not be required, and machine names being prepended to destination folder

Enter Task Name: WindowsMachineFileCopy Version 2

https://github.com/microsoft/azure-pipelines-tasks/blob/master/Tasks/WindowsMachineFileCopyV2/WindowsMachineFileCopy.ps1

Environment

• Server - Azure Dev Ops Release Pipeline

FootAsylumDevOps
Epos
releaseId=79

• Agent - Private:

OS: Windows 10
Agent Version: 2.195.2

Issue Description

Task : Windows machine file copy
Description : Copy files to remote Windows machines
Version : 2.1.13

The YAML snippet here specifies that "machineNames", "adminUserName" and "adminPassword" are parameters for the "sourcePath:" section, and that these parameters are all "optional".

However, in the code here we can see that all those parameters are required. And indeed if we don't set them on the task, we will get the error "[error]Required: 'MachineNames' input" as it can be seen in the logs of "Attempt #7". There should be no reason to forcing these parameters to be required.

Furthermore, the task is using machine names to build the target path, which is also incorrect. Note that as per the YAML the machine names is a parameter for the "sourcePath" section, but the task uses it to prepend to the "targetPath". This results in the task trying to copy the file to as many destinations as the machine names specified in source path. See logs in "Attempt #8"

Expected outcome:

• "machineNames", "adminUserName" and "adminPassword" should not be required parameters
• "machineNames" is a parameter for the "sourcePath" section, and not be used for the "targetPath" section
• "machineNames" should not be used to specify the destination path of the file being copied

Reproduce:

Scenario 1 -> "Attempt #7"

Deployment group job with two targets

Configuration of the Task with no machine names

Expect this to run and copy the file from source to target.

YAML for the task:
steps:

• task: WindowsMachineFileCopy@2
  displayName: 'Copy files from $(System.DefaultWorkingDirectory)/_epos-software-release-candidate-branch/drop/target/epos.war'
  inputs:
  SourcePath: '$(System.DefaultWorkingDirectory)/_epos-software-release-candidate-branch/drop/target/epos.war'
  TargetPath: 'C:\ProgramData\Tomcat9\webapps'

Scenario 2 -> "Attempt #8"

Deployment group job with two targets

Configuration of the Task with one machine name (just to show that this machine name will be used as target destination)

Task logs

1_Stage 1- Copy EPOS WAR FILE-2.zip

Troubleshooting

Could not find anything related to this issue.

Checkout how to troubleshoot failures and collect debug logs: https://docs.microsoft.com/en-us/vsts/build-release/actions/troubleshooting

Error logs

Scenario 1 Errors:

2021-12-29T12:24:26.8619797Z ##[error]Required: 'MachineNames' input

Scenario 2 Errors:

Fails on one deployment agent because machine name it is used to set the target path on this agent, and in that agent the target path does not exist, should not be prepending machine name to target path