Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button. #2236

Closed
JasonAment opened this issue Dec 14, 2018 · 10 comments · Fixed by #4020
Closed

Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button. #2236

JasonAment opened this issue Dec 14, 2018 · 10 comments · Fixed by #4020
Assignees
@shalinijoshi19
Labels
Area-Accessibility Bugs around feature accessibility Bug Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer
Milestone
20.05

Comments

@JasonAment
Copy link

Please reference the following bug for repro steps and videos:
microsoft/BotFramework-WebChat#1340
@corinagum corinagum mentioned this issue Dec 17, 2018
Closed
@dclaux dclaux mentioned this issue Mar 18, 2019
Closed
6 tasks
@shalinijoshi19 shalinijoshi19 self-assigned this Apr 10, 2020
@shalinijoshi19 shalinijoshi19 added Area-Accessibility Bugs around feature accessibility Bug HealthBotBlocker Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer labels Apr 10, 2020
@ghost ghost added the Triage-Needed label Apr 10, 2020
@compulim
Copy link
Contributor

Fixing this one should partially/fully fix the following issues:

@shalinijoshi19
Copy link
Member

This is also been identified as part of our Accessibility test pass ADO #23950535

@shalinijoshi19
Copy link
Member

@shalinijoshi19 to sync with @dclaux on getting this fixed.

@rp-dev
Copy link

rp-dev commented Apr 16, 2020

@shalinijoshi19 is there an ETA on the fix and when that'd be available in the release.

Thanks
Rohini

@rp-dev rp-dev mentioned this issue Apr 16, 2020
Closed
@shalinijoshi19
Copy link
Member

@dclaux for updates here. Thanks

@dclaux
Copy link
Member

dclaux commented Apr 16, 2020

I have been looking at this today and here are my findings:

  • The apparently desired behavior calls for removing the tab stop on the root card container
  • That would indeed be a better for anyone that has no disability and is able read and see the card
  • But removing that tab stop makes narrator not stop on the card, and thus not read it. That seems really bad to me when it comes to actual accessibility

So my conclusion:

  • "Fixing" this issue would favor power users over people with disabilities who use narration
  • I do not believe there is a fix; we need to keep the root card as a tab stop

I think we'll need to look into other ways to solve this if it is critical (is it?)

Thoughts and comments welcome.

@shalinijoshi19
Copy link
Member

@compulim FYI; please take a look at @dclaux's response above..

@shalinijoshi19
Copy link
Member

@dclaux fixing this is indeed high priority. @compulim could you take a look at @dclaux's comments above?

paulcam206 added a commit that referenced this issue May 15, 2020
@paulcam206
[JS] Make tabIndex on root card turnoffable
68e1a13 
Fixes #2236
@paulcam206 paulcam206 mentioned this issue May 15, 2020
Merged
paulcam206 added a commit that referenced this issue May 18, 2020
@paulcam206
[JS] Make tabIndex on root card turnoffable (#4020)
73e1271 
Fixes #2236
@paulcam206
Copy link
Member

This bug will be fixed in the next release, but will require callers to to set GlobalSettings.setTabIndexAtCardRoot to false if the desired behavior is for us not to emit a tabstop.

paulcam206 added a commit that referenced this issue May 28, 2020
@paulcam206
[JS] Make tabIndex on root card turnoffable (#4020)
f98f647 
Fixes #2236 in release/1.2
Original commit 73e1271
Original PR #4020
@paulcam206 paulcam206 mentioned this issue May 28, 2020
Merged
paulcam206 added a commit that referenced this issue May 28, 2020
@paulcam206
[JS] Make tabIndex on root card turnoffable (#4020)
7bba1b7 
Fixes #2236 in release/1.2
Original commit 73e1271
Original PR #4020
paulcam206 added a commit that referenced this issue May 29, 2020
@paulcam206
[JS] Make tabIndex on root card turnoffable (#4020) (#4068)
9e14155 
Fixes #2236 in release/1.2
Original commit 73e1271
Original PR #4020
@ghost
Copy link

ghost commented Jun 1, 2020

🎉[email protected] has been released which fixes this issue.:tada:

Handy links:

@paulcam206 paulcam206 mentioned this issue Jun 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shalinijoshi19 shalinijoshi19

Labels
Area-Accessibility Bugs around feature accessibility Bug Partner-MsftBotFramework Bugs related to Msft BotFramework integration with AdaptiveCards Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Milestone
20.05
Development

Successfully merging a pull request may close this issue.

[JS] Make tabIndex on root card turnoffable microsoft/AdaptiveCards
6 participants
@dclaux @compulim @paulcam206 @JasonAment @shalinijoshi19 @rp-dev