Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JS] Make tabIndex on root card turnoffable (#4020) #4068

Merged
merged 2 commits into from
May 29, 2020

Conversation

paulcam206
Copy link
Member

@paulcam206 paulcam206 commented May 28, 2020

Description

Fixes #2236 in release/1.2
Original commit 73e1271
Original PR #4020

How Verified

  • Local build, testing, and verification with F12 tools
Microsoft Reviewers: Open in CodeFlow

Fixes #2236 in release/1.2
Original commit 73e1271
Original PR #4020
@paulcam206 paulcam206 added Platform-JavaScript Bugs or features related to the JavaScript renderer Area-Accessibility Bugs around feature accessibility labels May 28, 2020
@ghost
Copy link

ghost commented May 28, 2020

Hi @paulcam206. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206 paulcam206 force-pushed the paulcam/port-tabindex-fix branch from f98f647 to 7bba1b7 Compare May 28, 2020 23:09
@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@paulcam206 paulcam206 merged commit 9e14155 into release/1.2 May 29, 2020
@paulcam206 paulcam206 deleted the paulcam/port-tabindex-fix branch May 29, 2020 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Accessibility Bugs around feature accessibility Platform-JavaScript Bugs or features related to the JavaScript renderer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant