Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAS2.4.3]Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button. #1340

Closed
priysn opened this issue Nov 13, 2018 · 9 comments · Fixed by #3193
Assignees
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. external-adaptive-cards front-burner
Milestone

Comments

@priysn
Copy link

priysn commented Nov 13, 2018

Actual Result:
Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button.

Expected Result:
Focus should not land on non-interactive elements after activating the 'Show a simple' Adaptive cards button.

Repro Steps:

  1. Open URL https://microsoft.github.io/BotFramework-WebChat/full-bundle/ in Edge browser.
  2. Notice 'Upload File' and 'Send' button icons present in bottom of screen.
  3. Type 'Help' in the input control at the bottom of the screen and hit enter (or click on send button).
    Content will upload, Navigate to any "Show a simple Adaptive cards " button by using Tab key and press Enter on it.
  4. New data will appear.
  5. Navigate to the new uploaded content by using Tab key.
  6. Observe that focus is landing on the non-interactive element.

User Impact:
If focus lands on the non-interactive elements then user will get confuse and not able to understand that what action will do.

MAS Reference:
MAS 2.4.3 - Focus Order (05)

Test Environment:
OS: Windows 10
OS Build: 17134.345
OS Version: 1803
Browser: Edge

****Attachment:
MAS2.4.3_Focus is landing on non-interactive element.zip
**

@priysn priysn added bug Indicates an unexpected problem or an unintended behavior. area-accessibility HCL_BotFramework_WebChat labels Nov 13, 2018
@sgellock sgellock added the 4.2 label Nov 13, 2018
@priysn priysn changed the title Focus is landing on the non-interactive elements after activate the "Show a simple Adaptive cards" button. [MAS2.4.3]Focus is landing on non-interactive elements after activate the "Show a simple Adaptive cards" button. Nov 14, 2018
@priysn priysn changed the title [MAS2.4.3]Focus is landing on non-interactive elements after activate the "Show a simple Adaptive cards" button. [MAS2.4.3]Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button. Nov 27, 2018
@priysn priysn self-assigned this Nov 27, 2018
@compulim
Copy link
Contributor

Adaptive Cards is setting tabIndex="0" to the root container, regardless whether the card is clickable or not. Some cards do support clicking on, but the "simple card" mentioned in this issue should not be clickable.

If you visit https://adaptivecards.io/samples/, you will see the DOM tree looks like the following screenshot.

image

This is a bug on Adaptive Cards. Please file a bug on their repo.

@compulim compulim added this to the v4.2 milestone Nov 28, 2018
@compulim
Copy link
Contributor

Reopening so we can confirm from the accessibility team.

@corinagum
Copy link
Contributor

corinagum commented Dec 3, 2018

Confirmed with accessibility team as external. Adaptive Cards issue can be found here.

@dclaux
Copy link
Member

dclaux commented Apr 16, 2020

I have been looking at this today and here are my findings:

  • The apparently desired behavior calls for removing the tab stop on the root card container
  • That would indeed be a better for anyone that has no disability and is able read and see the card
  • But removing that tab stop makes narrator not stop on the card, and thus not read it. That seems really bad to me when it comes to actual accessibility

So my conclusion:

  • "Fixing" this issue would favor power users over people with disabilities who use narration
  • I do not believe there is a fix; we need to keep the root card as a tab stop

I think we'll need to look into other ways to solve this if it is critical (is it?)

Thoughts and comments welcome.

@corinagum
Copy link
Contributor

@dclaux That's a really good point.

@awalia13, would you have time to look at this? Please let us know if we can close the issue on the AC repo as no-op, or if you have suggestions on another way to fix.

@awalia13
Copy link

Agreed with @dclaux. hence closing this bug.

@paulcam206
Copy link
Member

@awalia13 - you might consider reopening this issue, as we've made a fix over on the AdaptiveCards side (see microsoft/AdaptiveCards#4019). Narrator is indeed able to read cards correctly without a tabstop. To adopt this fix in your codebase, you'll need to make a small change to enable the desired behavior.

@ashish315
Copy link

@corinagum As we checked, the bug still repro's at our side.
Still our focus lands on the non interactive card which doesn't have any functionality. Please refer the attached video "focus lands on non interactive card.zip"

Uploading focus lands on non interactive card.zip…
Correct URL: https://microsoft.github.io/BotFramework-WebChat/01.getting-started/a.full-bundle/

@Amit8527510735
Copy link

Amit8527510735 commented Nov 17, 2020

#HCL;#Accessibility;#HCL_BotFramework_WebChat;#A11yMAS;#WCAG2.4.3;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-accessibility bug Indicates an unexpected problem or an unintended behavior. external-adaptive-cards front-burner
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants