Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility support #422

Closed
1 of 6 tasks
dclaux opened this issue Jun 13, 2017 · 4 comments
Closed
1 of 6 tasks

Accessibility support #422

dclaux opened this issue Jun 13, 2017 · 4 comments
Labels

Comments

@dclaux
Copy link
Member

dclaux commented Jun 13, 2017

Release Renderer status Tasks status
Backlog 🔄 .NET (#2473)
🔄 Android (#2474)
🔄 iOS (#2475)
🔄 TS (#1695)
🔄 UWP (#2476)
✔️ Shared (#2472)

Solves requests

Narration, keyboard navigation

Also need to consider

  • Use of proper HTML tags and attributes (e.g anchor element for hyperlinks, alt on image etc)
  • Support for ARIA attributes
  • Support for high contrast mode
  • Support for supplying high contrast images
  • backgroundColor on Image elements (letting authors supply high contrast colors)
  • Action.title should be a tooltip for selectActions where appropriate
  • Elements/Input and need an "ariaLabel" attribute that gets passed along to each renderer

Related details:

Also, Cortana ran into the following two issues on 7/5/2018 that need to be fixed...

Narrator is not narrating the state as "Collapsed/Expand" when user trigger on 'Set due date' button.
Solution: This needs aria-expanded property set on the showcard action in adaptive card.

Name property should be more descriptive for ‘calendar date’ edit box.
When screen reader focus land on 'calendar date' here narrator should narrate as 'Set due date dd/mm/yyyy'

JS issues Description
#2235 Name/ Alt-text property is not proprly defined for Images.
#2236 Focus is landing on non-interactive elements after activating the 'Show a simple' Adaptive cards button.
#2237 Name property does not defined for “Date" and "Time" editable text boxes from all card inputs data
#2238 Label is not properly associated with controls defined under 'What color do you want'.
#2239 Reading 'Group' between the text boxes while navigating in scan mode
#2240 Incorrect role is define for 'View details' control.
#2241 Meaningful sequence is not correct at 'Depart and Arrive' text content while navigating in scan mode.
#2242 'SurfacePro4 and Surface Pro 4 (2)' controls define as a button but visually looks like an Image on 'Receipt card' content

Auto-generated task status

  • Shared
  • .NET
  • Android
  • iOS
  • TS
  • UWP
@matthidinger matthidinger added this to the v1 milestone Jul 6, 2017
@matthidinger
Copy link
Member

matthidinger commented Aug 14, 2017

(comments merged into top of issue)

@dclaux
Copy link
Member Author

dclaux commented Aug 14, 2017

High contrast is addressed via HostConfig, I don't think we need anything else in that area.

@matthidinger matthidinger modified the milestones: v1.0-beta, v1.0 Sep 22, 2017
@khouzam khouzam removed this from the v1.0 milestone Nov 30, 2017
@yeohan
Copy link
Contributor

yeohan commented Apr 5, 2018

Here are three particular requests for iOS. This comes with these new properties in JSON - accessibility_label, accessibility_hint, and accessibility_role (could be renamed for better cross-platform support).

TextBlock as a Link

{
    "type": "TextBlock",
    "color": "accent",
    "size": "default",
    "maxLines": 99,
    "text": "+81 3 4535 3926",
    "horizontalAlignment": "left",
    "spacing": "none",
    "accessibility_label": "Phone number link +81 3 1234 5678",
    "accessibility_hint": "Double tap to make a phone call",
    "accessibility_role": "link"
}

VoiceOver should read this out, starting with the label (instead of the text), role, and the description. Say, "Phone number link +81 3 1234 5678", "link", "Double tap to make a phone call".

In this case, iOS UILabel should have these properties accordingly - accessibilityLabel, accessibilityHints, accessibilityTraits.

TextBlock as a Button

{
"type": "TextBlock",
"horizontalAlignment": "center",
"text": "Add contact",
"maxLines": 1,
"weight": "default",
"size": "default",
"spacing": "small",
"accessibility_hint": "Double tap to add a contact",
"accessibility_role": "button"
}

VoiceOver should read this out, starting with the text, role, and the description. Say, "Add contact", "button", "Double tap to add a contact".

In this case, iOS UILabel should have these properties accordingly - accessibilityHints, accessibilityTraits.

Inaccessible TextBlock (TextBlock as layout element)

{
"type": "TextBlock",
"horizontalAlignment": "center",
"text": "-",
"maxLines": 1,
"weight": "default",
"size": "default",
"spacing": "small",
"accessibility_enabled": false
}

VoiceOver should NOT read this element (ignore and skip moving focus onto it).

In this case, iOS UILabel should have these properties accordingly - isAccessibilityElement.

@andrewleader
Copy link
Contributor

Proposal too vague, need more specific details on what we're going to solve vs what's not supported today, and how big of an issue those things actually are before deciding whether we should do them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants