Limit non-English locales #3661
Conversation
@peterbe @Gregoor This was due to the presence of a URL with a retired locale in the content repo's |
|
@pertebe @Gregoor FYI, at first I implemented the retired-locale redirects directly in the lambda function, but then thought that perhaps a better place for that functionality was in the fundamental redirects (e.g., links to retired locales would be detected as flaws). As it stands, this PR places the redirect code in the fundamental redirects, but if you simply remove the last commit, the placement moves back into the lambda function. So we can easily go either way, depending on what we all think is best. |
|
Using the flaws sounds like a great idea to me and the codes does cohere to me. I am a little sad that we don't have code-sharing between the client and lib's constants, but it's only incidentally the first time I am noticing it and not too related to this PR (plus you kept it in sync here), so that's just a note on the side. |
| const r = await get("/BN/search?q=video"); | ||
| expect(r.statusCode).toBe(302); | ||
| expect(r.headers["location"]).toBe( | ||
| "/en-US/search?retiredLocale=bn&q=video" |
* update/add locale constants * add and test redirects of retired locales * fix locale alias for pt * fix for developing.test.js cookie test * fix gather-git-history * add integration tests for retired locale redirects * move redirects into the fundamental redirects * add lambda tests (feedbacked) * use DEFAULT_LOCALE (feedbacked)
* upstream/main: (288 commits) remove tests for obsolete search endpoints (mdn#3688) Limit non-English locales (mdn#3661) move footer icons to CSS bg images (mdn#3655) not all http:// links can be https:// (mdn#3657) add the lost part and update the translation for Express (mdn#3664) update the translation of the zh-TW (mdn#3663) Add a Specifications macro and extract a special specification section to the Document (mdn#3518) build(deps-dev): bump & migrate use-debounce to 6.0.0 (mdn#3684) build(deps-dev): bump puppeteer from 9.0.0 to 9.1.0 (mdn#3686) build(deps-dev): bump & migrate husky to 6.0.0 (mdn#3681) build(deps-dev): bump jest-environment-jsdom-sixteen from 1.0.3 to 2.0.0 (mdn#3615) More concurrent open npm PRs (mdn#3685) build(deps-dev): bump black from 21.4b0 to 21.4b2 in /deployer (mdn#3668) build(deps-dev): bump black in /testing/integration (mdn#3666) build(deps-dev): bump @babel/core from 7.13.16 to 7.14.0 (mdn#3683) build(deps-dev): bump jest-puppeteer from 5.0.2 to 5.0.3 (mdn#3680) build(deps): bump @mdn/browser-compat-data from 3.3.0 to 3.3.2 (mdn#3679) build(deps-dev): bump sass from 1.32.11 to 1.32.12 (mdn#3678) build(deps-dev): bump eslint-plugin-jest from 24.3.5 to 24.3.6 (mdn#3677) build(deps): bump http-proxy-middleware from 1.3.0 to 1.3.1 (mdn#3675) ...
Fixes #3665
Part of #3642
TODO (after merge):
*/docs/*Cloudfront behavior to useMDN-Noneforwarding policy on prod & dev (stage as already been done)