Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server start error due to _githistory.json [retired languages] #3665

Closed
tristantheb opened this issue May 1, 2021 · 4 comments · Fixed by #3661
Closed

Server start error due to _githistory.json [retired languages] #3665

tristantheb opened this issue May 1, 2021 · 4 comments · Fixed by #3661

Comments

@tristantheb
Copy link
Member

Following the deletion of the locales that were moved to a new repository, the Yari server throws an error for these locales when trying to launch it because it cannot find the _githistory.json.

To fix the server on my side, I reset my main branch before the deletion and restarted the server to at least have the _githistory.json once and not have any more problems, but users who will create the server with yari, content and translated-content might get an error to tell them that /ar/_githistory.json doesn't exist and the same for the other locales deleted from translated-content.

And on the Window side, nothing worked: yarn build returns an error, yarn dev returns an error. For the moment I have to keep the _githistory.json to be able to launch the server.

Maybe something needs to change on the Yari side so that withdrawn locals are not caught looking for them?

@escattone
Copy link
Contributor

escattone commented May 1, 2021

@tristantheb This was my fault, sorry! I have a fix for this already in #3661 (60703cf) which I'll pull out of that pull request and get merged today. Thanks for reporting!

@escattone
Copy link
Contributor

@tristantheb I realized that my idea of a quick fix wouldn't work without pulling in more of #3661, so I decided to wait until Monday for the review/merge of #3661 to fix this issue. Sorry again for the inconvenience.

@tristantheb
Copy link
Member Author

Hello :)

Thanks for the information ^^ It's more for the people who will want to set this up than for the people who already have it that it will be problematic, because those who have already done the setup before the retirement of the languages, we automatically kept the _githistory.json, the latter not being tracked by Git ^^

@peterbe
Copy link
Contributor

peterbe commented May 3, 2021

I'm confused. Ryan's changes haven't landed yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants