move footer icons to CSS bg images #3655
Conversation
peterbe
changed the title
| > | ||
| <TwitterIcon /> | ||
| <span className="visuall-hidden">MDN on Twitter</span> |
There was a problem hiding this comment.
Yeah, let me change it to Virtually. Btw let me know if other changes are needed as well :)
There was a problem hiding this comment.
Yup, as Peter mentioned, you can use the existing visually-hidden class here and the other places later in the file.
| .visuall-hidden { | ||
| display: none; | ||
| } |
There was a problem hiding this comment.
I don't believe you will need to add this. The utility class should already be exposed by minimalist. On the relevant HTML element you should be able to add className="visually-hidden" and it should just work.
|
Done with the changes 👍 |
|
@sohamsshah Can you merge in the latest |
|
Done with the changes, Please check :) |
There was a problem hiding this comment.
🎉 ❤️ Approved! Thank you so much for your valued contribution @sohamsshah
Do you know how to handle this, @sohamsshah? |
Interesting. Can you please brief me more about how to sign commits? Or send some resource to read about? Thanks. |
|
I copied GitHub's link to https://docs.github.com/en/github/authenticating-to-github/about-commit-signature-verification#gpg-commit-signature-verification (without the anchor for the above comment). Basically, it makes you create a GPG key (outlined in the above link) and upload it to GitHub. If you make changes within GitHub's web interface, GitHub will sign your changes for you. |
|
@sohamsshah Well done!! See if you can find the GitHub docs about how to set up git commit signing. It's a pain the back but you hopefully only have to do it once. Now, we need a more challenging bug for you to solve. :) |
|
Thank you so much @peterbe and @schalkneethling ! I will have a look at the existing issues. Curious, if you can also suggest me some good issue, so that I can start working on it :) |
What technologies are you most interested in or excited to work with? |
|
I am mostly into Frontend Development and love to explore component designs and architectures. Though, anything involving JS would excite me equally. |
https://github.com/mdn/yari/issues?q=is%3Aopen+is%3Aissue+label%3Afrontend+no%3Aassignee is a list of front-end issues that are not already assigned. |
* ↗ Fixes mdn#2900: move footer icons to CSS bg images * replace with utility class visually-hidden
* upstream/main: (288 commits) remove tests for obsolete search endpoints (mdn#3688) Limit non-English locales (mdn#3661) move footer icons to CSS bg images (mdn#3655) not all http:// links can be https:// (mdn#3657) add the lost part and update the translation for Express (mdn#3664) update the translation of the zh-TW (mdn#3663) Add a Specifications macro and extract a special specification section to the Document (mdn#3518) build(deps-dev): bump & migrate use-debounce to 6.0.0 (mdn#3684) build(deps-dev): bump puppeteer from 9.0.0 to 9.1.0 (mdn#3686) build(deps-dev): bump & migrate husky to 6.0.0 (mdn#3681) build(deps-dev): bump jest-environment-jsdom-sixteen from 1.0.3 to 2.0.0 (mdn#3615) More concurrent open npm PRs (mdn#3685) build(deps-dev): bump black from 21.4b0 to 21.4b2 in /deployer (mdn#3668) build(deps-dev): bump black in /testing/integration (mdn#3666) build(deps-dev): bump @babel/core from 7.13.16 to 7.14.0 (mdn#3683) build(deps-dev): bump jest-puppeteer from 5.0.2 to 5.0.3 (mdn#3680) build(deps): bump @mdn/browser-compat-data from 3.3.0 to 3.3.2 (mdn#3679) build(deps-dev): bump sass from 1.32.11 to 1.32.12 (mdn#3678) build(deps-dev): bump eslint-plugin-jest from 24.3.5 to 24.3.6 (mdn#3677) build(deps): bump http-proxy-middleware from 1.3.0 to 1.3.1 (mdn#3675) ...
Fixes #2900
Thank you MDN team for helping me out with this PR ❤ making OSS cakewalk for me haha ;)
Anyways, please review and let me know if any changes are needed, will be active with it.