-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move footer icons to CSS bg images #3655
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,4 @@ | ||
import * as React from "react"; | ||
|
||
import { ReactComponent as GithubIcon } from "@mdn/dinocons/brands/github-mark-small.svg"; | ||
import { ReactComponent as TwitterIcon } from "@mdn/dinocons/social/twitter.svg"; | ||
import { ReactComponent as InstagramIcon } from "@mdn/dinocons/social/instagram.svg"; | ||
|
||
import { useLocale } from "../../../hooks"; | ||
import { Logo } from "../../atoms/logo"; | ||
import "./index.scss"; | ||
|
@@ -76,22 +71,22 @@ export function Footer() { | |
<ul> | ||
<li> | ||
<a | ||
className="social-icon twitter" | ||
href="https://twitter.com/mozdevnet" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
aria-label="Twitter" | ||
> | ||
<TwitterIcon /> | ||
<span className="visuall-hidden">MDN on Twitter</span> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Typo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, let me change it to Virtually. Btw let me know if other changes are needed as well :) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yup, as Peter mentioned, you can use the existing |
||
</a> | ||
</li> | ||
<li> | ||
<a | ||
className="social-icon github" | ||
href="https://github.com/mdn/" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
aria-label="Github" | ||
> | ||
<GithubIcon /> | ||
<span className="visuall-hidden">MDN on Github</span> | ||
</a> | ||
</li> | ||
</ul> | ||
|
@@ -102,22 +97,22 @@ export function Footer() { | |
<ul> | ||
<li> | ||
<a | ||
className="social-icon github" | ||
href="https://twitter.com/mozilla" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
aria-label="Twitter" | ||
> | ||
<TwitterIcon /> | ||
<span className="visuall-hidden">Mozilla on Twitter</span> | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
className="social-icon instagram" | ||
href="https://www.instagram.com/mozillagram/" | ||
target="_blank" | ||
rel="noopener noreferrer" | ||
aria-label="Instagram" | ||
> | ||
<InstagramIcon /> | ||
<span className="visuall-hidden">Mozilla on Instagram</span> | ||
</a> | ||
</li> | ||
</ul> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe you will need to add this. The utility class should already be exposed by minimalist. On the relevant HTML element you should be able to add
className="visually-hidden"
and it should just work.