-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove duplicate/misplaced api.Element.attachInternals entry #11556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
added
the
needs content update
This PR needs a corresponding update to mdn/content to update the documentation
label
Jul 16, 2021
github-actions
bot
added
the
data:api
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
label
Jul 16, 2021
foolip
added a commit
to foolip/content
that referenced
this pull request
Jul 16, 2021
MDN changes in mdn/content#6976. |
foolip
removed
the
needs content update
This PR needs a corresponding update to mdn/content to update the documentation
label
Jul 16, 2021
foolip
added a commit
to foolip/content
that referenced
this pull request
Jul 16, 2021
queengooborg
approved these changes
Jul 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch, thank you! I'm approving, but will hold off on merging until the content PR is merged.
sideshowbarker
pushed a commit
to mdn/content
that referenced
this pull request
Jul 17, 2021
sideshowbarker
approved these changes
Jul 17, 2021
sideshowbarker
force-pushed
the
dedupe-attachInternals
branch
from
July 17, 2021 06:46
ce17d3d
to
4aa6a75
Compare
ddbeck
added a commit
to ddbeck/browser-compat-data
that referenced
this pull request
Jul 22, 2021
ddbeck
added a commit
that referenced
this pull request
Jul 22, 2021
* Bump version to v3.3.12 * Add release note for #11661 * Add release notes for #11173 and #11175 * Add release note for #11534 * Add release note for #11544 * Add release note for #11551 * Add release note for #11555 * Add release note for #11556 * Add release note for #11557 * Add release note for #11633 * Add release note for #11636 * Add release note for #11637 * Add release note for #11530 * Add release stats and date * Consolidate Safari for iOS version consolidation notes * Format PR URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally added both:
#8112
#11245