Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate/misplaced api.Element.attachInternals entry #11556

Merged
merged 1 commit into from
Jul 17, 2021

Conversation

foolip
Copy link
Contributor

@foolip foolip commented Jul 16, 2021

We accidentally added both:
#8112
#11245

@foolip foolip added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 16, 2021
@foolip foolip requested a review from queengooborg July 16, 2021 15:02
@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jul 16, 2021
foolip added a commit to foolip/content that referenced this pull request Jul 16, 2021
@foolip
Copy link
Contributor Author

foolip commented Jul 16, 2021

MDN changes in mdn/content#6976.

@foolip foolip removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 16, 2021
foolip added a commit to foolip/content that referenced this pull request Jul 16, 2021
Copy link
Contributor

@queengooborg queengooborg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, thank you! I'm approving, but will hold off on merging until the content PR is merged.

@sideshowbarker sideshowbarker force-pushed the dedupe-attachInternals branch from ce17d3d to 4aa6a75 Compare July 17, 2021 06:46
@sideshowbarker sideshowbarker merged commit ff97bfe into mdn:main Jul 17, 2021
@foolip foolip deleted the dedupe-attachInternals branch July 17, 2021 18:44
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 22, 2021
ddbeck added a commit that referenced this pull request Jul 22, 2021
* Bump version to v3.3.12

* Add release note for #11661

* Add release notes for
#11173 and #11175

* Add release note for #11534

* Add release note for #11544

* Add release note for #11551

* Add release note for #11555

* Add release note for #11556

* Add release note for #11557

* Add release note for #11633

* Add release note for #11636

* Add release note for #11637

* Add release note for #11530

* Add release stats and date

* Consolidate Safari for iOS version consolidation notes

* Format PR URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants