DateTimeFormat - restructure constructor parameters

[hamishwillee]

This follows on from #11501

This is just the first step - restructure the constructor to use subfeatures for parameters, and subfeatures of those for options.

I am in no way sure this is "correct" so this is a first step.

Following on from this I will need to add the new values for timeZoneName added in FF91 - see https://bugzilla.mozilla.org/show_bug.cgi?id=1710429.

[hamishwillee]

The next step is to add options_timeZoneName_parameter.

1. My inference is that I create options_timeZoneName_parameter with a subfeature options_timeZoneName_parameter_ana to mirror the timeZone care - right?
2. What do I put for the versions in options_timeZoneName_parameter - do I just assume this option was introduced at the earliest versions of the constructor?
3. Can you help me work out what version of v8 the new options went into?

[Elchi3]

• My inference is that I create options_timeZoneName_parameter with a subfeature options_timeZoneName_parameter_ana to mirror the timeZone care - right?

This works, I wonder if we're nesting too deep at this point. I think it wouldn't hurt to have it at the same level. I have no strong feeling.

• What do I put for the versions in options_timeZoneName_parameter - do I just assume this option was introduced at the earliest versions of the constructor?

I think that makes sense, yes.

• Can you help me work out what version of v8 the new options went into?

I can't unfortunately.

[Elchi3]

Given options is an object, a dot feels better to me.

[hamishwillee]

@Elchi3 Thanks for your review and advice: #11544 (comment)

I have merged your suggestions, and also updated the timeZone versions to match the constructor, where they didn't already.

Lastly I have added the timeZoneName option and iana subfeatures, mirroring those for timeZone. That makes sense because whether or not it is too deeply nested, we should be consistent. All other browsers are marked false for the new feature - though I only tested on latest Chrome.

I think ready for rereview.

[Elchi3]

Thanks Hamish! 👍

[ddbeck]

This PR affected the following features:

Removed

• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.dateStyle
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.dayPeriod
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.fractionalSecondDigits
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.hourCycle
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.iana_time_zone_names
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.timeStyle

Added

• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.locales_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_dateStyle_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_dayPeriod_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_fractionalSecondDigits_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_hourCycle_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_timeStyle_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_timeZone_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_timeZone_parameter.options_timeZone_parameter_iana
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_timeZoneName_parameter
• javascript.builtins.Intl.DateTimeFormat.DateTimeFormat.options_parameter.options_timeZoneName_parameter.options_timeZoneName_parameter_iana