Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Safari iOS 5.1 #11175

Merged
merged 6 commits into from
Jul 16, 2021
Merged

Remove Safari iOS 5.1 #11175

merged 6 commits into from
Jul 16, 2021

Conversation

queengooborg
Copy link
Contributor

This PR removes Safari iOS 5.1 from the browser data, and changes everything set to Safari iOS 5.1 to mirrored data from Safari Desktop. Safari iOS 5.1's WebKit version is the exact same as iOS 5.0's, as confirmed by querying WhatIsMyBrowser.

Using the Safari iOS 4 emulator in BrowserStack, I've spot-checked a few entries to ensure this methodology is correct. I have also found that all of the data for Safari iOS 351 came from the initial wiki tables, and most entries are accompanied by Safari Desktop set to 5.1, which further leads me to believe that Safari iOS 5.1 was mistakenly added.

An additional note is that worker support was indeed pushed back to a later release in Safari iOS than Safari Desktop, probably due to OS implementation or the likes. I've set its version to 5.0.

@github-actions github-actions bot added data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:mathml Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML labels Jun 21, 2021
@foolip
Copy link
Contributor

foolip commented Jun 21, 2021

I've found some additional sources of the UA strings:

https://stackoverflow.com/a/7825888 says:

Mozilla/5.0 (iPhone; CPU iPhone OS 5_0 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A334 Safari/7534.48.3

https://pypi.org/project/user-agents-next/ says, in an example:

Mozilla/5.0 (iPhone; CPU iPhone OS 5_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9B179 Safari/7534.48.3

So it looks like the WebKit version is 534.46 for both and the corresponding Safari version is 5.1 for both.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken all the matching 5+5.1 as trustworthy, and have commented on any Safari + iOS pairs other than that. With those investigated I'd be confident that this isn't changing data in the wrong direction.

api/KeyboardEvent.json Show resolved Hide resolved
api/MessageChannel.json Show resolved Hide resolved
api/SharedWorker.json Show resolved Hide resolved
api/Window.json Outdated Show resolved Hide resolved
api/WindowEventHandlers.json Outdated Show resolved Hide resolved
api/XMLHttpRequest.json Outdated Show resolved Hide resolved
css/selectors/before.json Outdated Show resolved Hide resolved
html/elements/input/range.json Outdated Show resolved Hide resolved
javascript/builtins/DataView.json Outdated Show resolved Hide resolved
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jun 29, 2021
@foolip
Copy link
Contributor

foolip commented Jul 16, 2021

@vinyldarkscratch are you planning to go through the comments to finish this?

@queengooborg
Copy link
Contributor Author

I am, yeah -- I found out that BrowserStack has an iPad on iOS 4.3 emulator, so I can collect the results for iOS 4.2! I'll be tackling that soon.

Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've gone through everything again and found a few more irregular things that I'm not sure about.

api/KeyboardEvent.json Outdated Show resolved Hide resolved
api/MessagePort.json Outdated Show resolved Hide resolved
api/WebSocket.json Show resolved Hide resolved
api/Window.json Outdated Show resolved Hide resolved
api/WindowEventHandlers.json Outdated Show resolved Hide resolved
html/elements/input/range.json Show resolved Hide resolved
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed end-to-end yet again, all looks nice and orderly now! Thanks Vinyl!

@foolip foolip merged commit ee86f6a into mdn:main Jul 16, 2021
@queengooborg queengooborg deleted the browsers/safari-ios/5.1 branch July 16, 2021 17:46
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 22, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jul 22, 2021
ddbeck added a commit that referenced this pull request Jul 22, 2021
* Bump version to v3.3.12

* Add release note for #11661

* Add release notes for
#11173 and #11175

* Add release note for #11534

* Add release note for #11544

* Add release note for #11551

* Add release note for #11555

* Add release note for #11556

* Add release note for #11557

* Add release note for #11633

* Add release note for #11636

* Add release note for #11637

* Add release note for #11530

* Add release stats and date

* Consolidate Safari for iOS version consolidation notes

* Format PR URL
foolip added a commit to foolip/browser-compat-data that referenced this pull request Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers Data about browsers (versions, release dates, etc). This data is used for validation. data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML data:http Compat data for HTTP features. https://developer.mozilla.org/docs/Web/HTTP data:js Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:mathml Compat data for MathML features. https://developer.mozilla.org/docs/Web/MathML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants