-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Safari iOS 5.1 #11175
Remove Safari iOS 5.1 #11175
Conversation
I've found some additional sources of the UA strings: https://stackoverflow.com/a/7825888 says:
https://pypi.org/project/user-agents-next/ says, in an example:
So it looks like the WebKit version is 534.46 for both and the corresponding Safari version is 5.1 for both. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've taken all the matching 5+5.1 as trustworthy, and have commented on any Safari + iOS pairs other than that. With those investigated I'd be confident that this isn't changing data in the wrong direction.
Based on UA strings: mdn#11175 (comment)
@vinyldarkscratch are you planning to go through the comments to finish this? |
I am, yeah -- I found out that BrowserStack has an iPad on iOS 4.3 emulator, so I can collect the results for iOS 4.2! I'll be tackling that soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've gone through everything again and found a few more irregular things that I'm not sure about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed end-to-end yet again, all looks nice and orderly now! Thanks Vinyl!
* Bump version to v3.3.12 * Add release note for #11661 * Add release notes for #11173 and #11175 * Add release note for #11534 * Add release note for #11544 * Add release note for #11551 * Add release note for #11555 * Add release note for #11556 * Add release note for #11557 * Add release note for #11633 * Add release note for #11636 * Add release note for #11637 * Add release note for #11530 * Add release stats and date * Consolidate Safari for iOS version consolidation notes * Format PR URL
Based on UA strings: mdn#11175 (comment)
This PR removes Safari iOS 5.1 from the browser data, and changes everything set to Safari iOS 5.1 to mirrored data from Safari Desktop. Safari iOS 5.1's WebKit version is the exact same as iOS 5.0's, as confirmed by querying WhatIsMyBrowser.
Using the Safari iOS 4 emulator in BrowserStack, I've spot-checked a few entries to ensure this methodology is correct. I have also found that all of the data for Safari iOS 351 came from the initial wiki tables, and most entries are accompanied by Safari Desktop set to 5.1, which further leads me to believe that Safari iOS 5.1 was mistakenly added.
An additional note is that worker support was indeed pushed back to a later release in Safari iOS than Safari Desktop, probably due to OS implementation or the likes. I've set its version to 5.0.