-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Safari iOS 3.1 #11173
Remove Safari iOS 3.1 #11173
Conversation
How can I do this? Did you visit https://www.whatismybrowser.com/ with iOS 3.0 and 3.1, or is there a way to query their database?
Did you use the mirroring script? Since the mapping before Safari / iOS 9 is not as trivial, I'm skeptical of any existing code for this :) |
I've looked for UA strings and came up with this: https://developers.whatismybrowser.com/useragents/parse/841safari-ios-iphone-webkit has:
https://user-agents.net/s/o05iLj has:
https://user-agents.net/s/rxAjIRSBrt has:
There's some weird tokens in some of those strings, but 528.18 is in all of them. And it seems reasonable to say that Safari 4 ≈ iOS 3. But only as an approximation, the WebKit versions don't match. |
Let's also consider the UA string of iOS 3.2 from https://stackoverflow.com/a/5255476:
That 4.0.4 probably means Safari 4, and 531.21.10 also appears in https://en.wikipedia.org/wiki/Safari_version_history#Safari_4 so it all makes sense. It does however make me question whether we should consider iOS 3.2 significant. |
If we trust our
If we throw Wikipedia into the mix we could add:
I don't know how the branching was done, but if we just consider the WebKit version numbers and the UA strings (above) it seems like Safari 4 maps to either iOS 3 or 3.2. It seems unlikely to me that there's much difference between the two since the same differences on desktop were just treated as patch versions. |
To review this, it's also necessary to understand (believe) the Safari 3.1 → iOS 2 mapping. Wikipedia supports the 525.13 WebKit version we have in https://www.w3.org/2007/03/mth/9e573d0661a52f38282af0a625fd32fc.html has:
https://developers.whatismybrowser.com/useragents/parse/829764safari-ios-ipod-webkit has:
Note the 3.1.1 there, which is the Safari version. So that all supports the mapping Safari 3.1 → iOS 2. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust the cases that are now 4+3 or 3.1+2 and have commented on all cases that aren't either pair. With those checked I think this change is good to go.
Based on UA strings: mdn#11173 (comment) mdn#11173 (comment)
@vinyldarkscratch what's this blocked on now? Do I just need to review again? |
It just needs a re-review now, yep! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reviewed top-to-bottom again without finding any irregularities to poke at.
* Bump version to v3.3.12 * Add release note for #11661 * Add release notes for #11173 and #11175 * Add release note for #11534 * Add release note for #11544 * Add release note for #11551 * Add release note for #11555 * Add release note for #11556 * Add release note for #11557 * Add release note for #11633 * Add release note for #11636 * Add release note for #11637 * Add release note for #11530 * Add release stats and date * Consolidate Safari for iOS version consolidation notes * Format PR URL
Based on UA strings: mdn#11173 (comment) mdn#11173 (comment)
This PR removes Safari iOS 3.1 from the browser data, and changes everything set to Safari iOS 3.1 to mirrored data from Safari Desktop. Safari iOS 3.1's WebKit version is the exact same as iOS 3.0's, as confirmed by querying WhatIsMyBrowser.
Using the Safari 3 emulator in BrowserStack, I've spot-checked a few entries to ensure this methodology is correct. I have also found that all of the data for Safari iOS 3.1 came from the initial wiki tables, and most entries are accompanied by Safari Desktop set to 3.1, which further leads me to believe that Safari iOS 3.1 was mistakenly added.
Blocked by #11188.