Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alpha.3] Dynamical DataGrid column changing not followed with List rerendering #3631

Closed
tusmenko opened this issue Aug 30, 2019 · 2 comments
Labels

Comments

@tusmenko
Copy link

tusmenko commented Aug 30, 2019

What you were expecting:
I expect to be able to dynamically configure columns set in DataGrid

What happened instead:
Only header row changes its configuration, on column config change without page reload.

Steps to reproduce:

  • Go to codesandbox
  • Open Posts view
  • Click first Toggle Columns button
  • Consider only header row config changed

Related code:
https://codesandbox.io/s/simple-ju5rm

Consider Toggle Columns button behavior - when columns configuration depends on state, when config in state changes - only header row updates configuration.
If config stored in the cache - columns are rendered correctly on page reloading.

Other information:
This reproduced only on 3.0 alpha version.
Quite similar behavior observed with ra-customizable-datagrid module, even if this module rerenders all selected DataGrid children under the hood, instead of conditional rendering one-by-one. Previously it worked fine.
If there are some backward incompatible changes in DataGrid, I'll be glad for some guidance about them, to find a way to fix external package.

Environment

  • React-admin version: "^3.0.0-alpha.3",
  • Last version that did not exhibit the issue (if applicable): 2.9.x
  • React version: ~16.8.0
  • Browser: Chrome
@tusmenko tusmenko changed the title Dynamical DataGrid column changing not followed with List rerendering [alpha.3] Dynamical DataGrid column changing not followed with List rerendering Aug 30, 2019
@djhi
Copy link
Collaborator

djhi commented Sep 2, 2019

Thanks a lot for reporting and the reproduction sandbox :)

@fzaninotto
Copy link
Member

Fixed by #3635

heesienooi added a commit to heesienooi/react-admin that referenced this issue Oct 17, 2019
* next:
  Fix typos in docs.
  Fix typos
  Export optimized components
  Review
  Fix documentation
  Fix defaultI18nProvider Export Fixes marmelab#3819
  Fix Warnings Displayed when Overriding Filter Classes Fixes marmelab#3800
  Fix NumberInput
  Make dependencies explicit to make code easier to understand
  Fix FinalForm Props Leak to Root Component Fixes marmelab#3810
  Review
  Fix typo
  Documentation
  Review
  Fix Datagrid can't handle dynamic children Fixes marmelab#3631 and marmelab#3629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants