Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultI18nProvider not exported #3819

Closed
thclark opened this issue Oct 14, 2019 · 4 comments
Closed

defaultI18nProvider not exported #3819

thclark opened this issue Oct 14, 2019 · 4 comments
Labels

Comments

@thclark
Copy link

thclark commented Oct 14, 2019

What you were expecting:
I'm following the instructions in CustomApp.md for creating a store. I was expecting everything to go smoothly, but...

What happened instead:
I got Attempted import error: 'defaultI18nProvider' is not exported from 'react-admin'.

Steps to reproduce:
With Release 3.0.0-beta-0 installed...

import { defaultI18nProvider } from "react-admin";

Other information:
I think that import is no longer necessary and should have been removed as part of this commit

Environment

  • React-admin version: 3.0.0-beta-0
djhi added a commit that referenced this issue Oct 14, 2019
@djhi
Copy link
Collaborator

djhi commented Oct 14, 2019

Thanks!

@thclark
Copy link
Author

thclark commented Oct 14, 2019

Actually, there's a paragraph in the preamble of htat page that should probably be adjusted to match too:
"React-admin requires that the redux state contains at least 3 reducers: admin, i18n and router. "

(sorry, I'd link to the line, but github renders markdown instead of allowing us to crossreference it like code).

@djhi
Copy link
Collaborator

djhi commented Oct 14, 2019

Good catch :) Thanks again!

@fzaninotto
Copy link
Member

Fixed by #3820

heesienooi added a commit to heesienooi/react-admin that referenced this issue Oct 17, 2019
* next:
  Fix typos in docs.
  Fix typos
  Export optimized components
  Review
  Fix documentation
  Fix defaultI18nProvider Export Fixes marmelab#3819
  Fix Warnings Displayed when Overriding Filter Classes Fixes marmelab#3800
  Fix NumberInput
  Make dependencies explicit to make code easier to understand
  Fix FinalForm Props Leak to Root Component Fixes marmelab#3810
  Review
  Fix typo
  Documentation
  Review
  Fix Datagrid can't handle dynamic children Fixes marmelab#3631 and marmelab#3629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants