Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.0.0-beta.0] Filter Component: Error when overriding CSS classes button and form #3800

Closed
MiMo42 opened this issue Oct 10, 2019 · 1 comment
Closed

[3.0.0-beta.0] Filter Component: Error when overriding CSS classes button and form #3800

MiMo42 opened this issue Oct 10, 2019 · 1 comment
Labels
bug v3

Comments

@MiMo42
Copy link
Contributor

MiMo42 commented Oct 10, 2019

What you were expecting:
It should be possible to override form and button CSS styles of Filter component without errors.
See documentation: https://github.com/marmelab/react-admin/blob/next/docs/Theming.md

What happened instead:
Runtime errors:

Material-UI: the key `form` provided to the classes prop is not implemented in undefined.
You can only override one of the following: root. 
    in FilterButton (at Filter.js:36)
    in Filter (at Filter.tsx:81)

and

Material-UI: the key `button` provided to the classes prop is not implemented in undefined.
You can only override one of the following: root. 
    in FilterButton (at Filter.js:36)
    in Filter (at Filter.tsx:81)

Steps to reproduce:
Override CSS styles like documented.

Related code:
https://stuzk.csb.app/posts
See material-ui errors in console

Environment

  • React-admin version: 3.0.0-beta.0
  • React version: 16.9
  • Browser: Chrome
@Kmaschta Kmaschta added the v3 label Oct 10, 2019
djhi added a commit that referenced this issue Oct 14, 2019
@djhi
Fix Warnings Displayed when Overriding Filter Classes
ebab4b9 
Fixes #3800
@djhi djhi mentioned this issue Oct 14, 2019
Merged
djhi added a commit that referenced this issue Oct 14, 2019
@djhi
Fix Warnings Displayed when Overriding Filter Classes
4eec3b2 
Fixes #3800
@djhi djhi added the bug label Oct 14, 2019
@fzaninotto
Copy link
Member

Fixed by #3817

heesienooi added a commit to heesienooi/react-admin that referenced this issue Oct 17, 2019
@heesienooi
Merge branch 'next' into fork
95b8e77 
* next:
  Fix typos in docs.
  Fix typos
  Export optimized components
  Review
  Fix documentation
  Fix defaultI18nProvider Export Fixes marmelab#3819
  Fix Warnings Displayed when Overriding Filter Classes Fixes marmelab#3800
  Fix NumberInput
  Make dependencies explicit to make code easier to understand
  Fix FinalForm Props Leak to Root Component Fixes marmelab#3810
  Review
  Fix typo
  Documentation
  Review
  Fix Datagrid can't handle dynamic children Fixes marmelab#3631 and marmelab#3629
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v3
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@fzaninotto @MiMo42 @djhi @Kmaschta