[RFR] Fix Datagrid can't handle dynamic children #3635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzaninotto
requested changes
Sep 3, 2019
There was a problem hiding this comment.
As discussed with @djhi, the use of memo here is useless as the children prop will change at every render. Therefore, the performance is not really good. We must add an optimized flag allowing to turn on speed optimizations when the columns of the datagrid don't change.
|
@fzaninotto I just tried this branch again with a CPU throttle set to x6 and I haven't notice any performance issues nor differences with the version without this fix. Can you try again ? |
djhi
changed the title
djhi
changed the title
fzaninotto
requested changes
Oct 8, 2019
| @@ -91,7 +82,11 @@ DatagridBody.defaultProps = { | |||
| row: <DatagridRow />, | |||
| }; | |||
|
|
|||
| const MemoDatagridBody = memo(DatagridBody); | |||
There was a problem hiding this comment.
memo doesn't work here as children will always change
|
I think the default export should be DatagridBody, not MemoDatagridBody |
fzaninotto
approved these changes
Oct 15, 2019
This was referenced Oct 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3631 and #3629