Fix issue #10565 #10575
Merged
Fix issue #10565 #10575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php
|
Please also backport this in the 2.1.x branch. This is also broken on the production release 2.1.8 |
|
@thlassche It would be nice to cover this case with a JS test. You may just update the existing one. |
|
@ishakhsuvarov Ok, will try to find some time this evening |
|
@thlassche Thanks a lot. Please let us know if you need any help with it. |
|
@ishakhsuvarov Just added the tests |
|
@thlassche Thank you |
magento-team
pushed a commit
that referenced
this pull request
Aug 19, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
Fixed issues: - MAGETWO-71552: Attribute values on store view level not searchable - for 2.2 - MAGETWO-72866: Redundant indexers invalidation - RIATCS-340 - MAGETWO-75458: [Backport] - Fix overwrite default value image/file with NULL #10253 - for 2.2 - MAGETWO-75460: [Backport] - LowestPriceOptionsProvider returns products without attributes which are used for price calculation (e.g. tax adjustment) - MAGETWO-80193: [2.2.x] - Add cast to string for CUST_GROUP_ALL #10475 - MAGETWO-80204: [2.2.x] - Grammar fix for #9533 #10627 - MAGETWO-71549: Impossible to export Advanced Prices on a medium profile - MAGETWO-80198: [2.2.x] - Fix issue #10565 #10575 - MAGETWO-80197: [2.2.x] - Fix JS translation search #10445 - MAGETWO-80195: [2.2.x] - Send different base currency in Google analytics #10508
hostep
pushed a commit
to hostep/magento2
that referenced
this pull request
Feb 7, 2018
…gento#10575 (cherry picked from commit b73d513)
4 tasks
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 21, 2018
magento-engcom-team
pushed a commit
that referenced
this pull request
Feb 21, 2018
magento-engcom-team
added a commit
that referenced
this pull request
Feb 21, 2018
Accepted Public Pull Requests: - #13549: Backport of MAGETWO-80198 for Magento 2.1: Fix issue #10565 #10575 (by @hostep) - #13543: Backport of MAGETWO-69379 for Magento 2.1: use payment method name to� (by @hostep) Fixed GitHub Issues: - #10565: Magento ver. 2.1.8 New Product with Custom attribute set not working (reported by @gilbertsohal) has been fixed in #13549 by @hostep in 2.1-develop branch Related commits: 1. d95e15c - #6207: Checkbox IDs for Terms and Conditions should be unique in Checkout (reported by @bka) has been fixed in #13543 by @hostep in 2.1-develop branch Related commits: 1. 6ec9e22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Creation of a new product with custom attribute set now works again
Description
85db4c8#diff-620105b6e833499c14f4eb74ce8a4532 introduced some changes wich broke the add new product screen when choosing a custom attribute set with a multiselect attribute in it. This pull request fixes that
Fixed Issues
Manual testing scenarios
Contribution checklist