Send different base currency in Google analytics #10508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t base currencies configured for different websites in a multisite and as a result need to send different currency in Google analytics
ishakhsuvarov
requested changes
Aug 15, 2017
| @@ -120,6 +120,7 @@ public function getOrdersTrackingCode() | |||
| $result[] = "ga('require', 'ec', 'ec.js');"; | |||
|
|
|||
| foreach ($collection as $order) { | |||
| $result[] = "ga('set', 'currencyCode', '" . $order->getBaseCurrencyCode() . "');"; | |||
There was a problem hiding this comment.
Looks like BaseCurrencyCode is not exactly the currency code needed here. With the multi-store setup it will always be the same, regardless of different display currency.
…esn't return default currency as base currency
magento-team
pushed a commit
that referenced
this pull request
Aug 16, 2017
magento-team
pushed a commit
that referenced
this pull request
Aug 16, 2017
[EngCom] Public Pull Requests - MAGETWO-71539: Send different base currency in Google analytics #10508
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
magento-team
pushed a commit
that referenced
this pull request
Oct 10, 2017
Fixed issues: - MAGETWO-71552: Attribute values on store view level not searchable - for 2.2 - MAGETWO-72866: Redundant indexers invalidation - RIATCS-340 - MAGETWO-75458: [Backport] - Fix overwrite default value image/file with NULL #10253 - for 2.2 - MAGETWO-75460: [Backport] - LowestPriceOptionsProvider returns products without attributes which are used for price calculation (e.g. tax adjustment) - MAGETWO-80193: [2.2.x] - Add cast to string for CUST_GROUP_ALL #10475 - MAGETWO-80204: [2.2.x] - Grammar fix for #9533 #10627 - MAGETWO-71549: Impossible to export Advanced Prices on a medium profile - MAGETWO-80198: [2.2.x] - Fix issue #10565 #10575 - MAGETWO-80197: [2.2.x] - Fix JS translation search #10445 - MAGETWO-80195: [2.2.x] - Send different base currency in Google analytics #10508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've encountered a scenario where payment providers require different base currencies configured for different websites in a multisite and as a result need to send different base currency in Google analytics
Fixed Issues (if relevant)
Manual testing scenarios
Contribution checklist