fixed notice when remove column from grid #10579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@magekey Thanks you for the Pull Request. Please sign the CLA with the actual email used for the commit so we will be able to proceed with the merge |
magento-team
pushed a commit
that referenced
this pull request
Aug 19, 2017
|
@magekey thank you for your contribution! |
|
@magento-team Will this get backported to 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magento 2.1.8
PHP 7.0.22
Description
Magento 2.1.8
PHP 7.0.22
$adminGrid->removeColumn('column_name');
Notice: Only variables should be passed by reference in Magento/Backend/Block/Widget/Grid/Extended.php on line 314