Performance: getConfigurableAttributes cache is broken

[paales]

Preconditions

1. 2.1.2
2. Have configurables

Steps to reproduce

1. After loading the configurable attributes it stores the result in the cache.
2. After loading the second time it tries to load it from the cache, but the hasCacheData method always returns false

Expected result

1. Should use cache

Actual result

1. Doesn't use cache

The two selected lines should be replaced:

magento2/app/code/Magento/ConfigurableProduct/Model/Product/Type/Configurable.php

Lines 446 to 447 in 1ade3b7

	$configurableAttributes = $configurableAttributes ?: unserialize($configurableAttributes);
	if (is_array($configurableAttributes) && count($configurableAttributes)) {

With

$configurableAttributes = $configurableAttributes ? unserialize($configurableAttributes) : false;
if (is_object($configurableAttributes) && $configurableAttributes->count()) {

[thlassche]

@paales Your proposed check was not sufficient. I opened a pull request (#7376) for this.

[paales]

Hmm, I haven't experienced that it is still an array.. Maybe Magento could write some tests to check this ;)

[magento-team]

Internal ticket to track issue progress: MAGETWO-69587

[thlassche]

@magento-team It's already fixed in a merged PR to develop

[korostii]

Never mind that, @magento-team's comment seems to be automatic. The bot is probably walking through all the internal ticket references it has, no matter the status.

[magento-engcom-team]

@paales the issue already fixed in 2.1.10 and will be available soon