Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator. #22190

Closed
lfluvisotto opened this issue Apr 7, 2019 · 5 comments
Closed

Exception (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator. #22190

lfluvisotto opened this issue Apr 7, 2019 · 5 comments
Assignees
@lfluvisotto
Labels
Component: Msrp Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release

Comments

@lfluvisotto
Copy link
Contributor

lfluvisotto commented Apr 7, 2019 •
edited
Loading

Preconditions (*)

  1. branch 2.3-develop
  2. nginx 1.14.3
  3. php 7.2.16
  4. mysql 5.7.25

Steps to reproduce (*)

  1. fresh installation of branch 2.3-develop
  2. disable the modules Magento_MsrpConfigurableProduct and Magento_MsrpGroupedProduct
  3. create any simple product
  4. create any category
  5. add the created simple product to the created category
  6. open the home page
  7. try to open the created category or search for the created simple product

Expected result (*)

  1. open the category catalog page
  2. open the search page

Actual result (*)

1 exception(s):
Exception #0 (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator.

Exception #0 (BadMethodCallException): Missing required argument $msrpPriceCalculators of Magento\Msrp\Pricing\MsrpPriceCalculator.
#1 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments() called at [lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:59]
#2 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() called at [lib/internal/Magento/Framework/ObjectManager/ObjectManager.php:70]
#3 Magento\Framework\ObjectManager\ObjectManager->get() called at [app/code/Magento/Msrp/Helper/Data.php:82]
#4 Magento\Msrp\Helper\Data->__construct() called at [lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php:116]
#5 Magento\Framework\ObjectManager\Factory\AbstractFactory->createObject() called at [lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:66]
#6 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() called at [lib/internal/Magento/Framework/ObjectManager/ObjectManager.php:70]
#7 Magento\Framework\ObjectManager\ObjectManager->get() called at [lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php:160]
#8 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgument() called at [lib/internal/Magento/Framework/ObjectManager/Factory/AbstractFactory.php:246]
#9 Magento\Framework\ObjectManager\Factory\AbstractFactory->resolveArgumentsInRuntime() called at [lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:34]
#10 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->_resolveArguments() called at [lib/internal/Magento/Framework/ObjectManager/Factory/Dynamic/Developer.php:59]
#11 Magento\Framework\ObjectManager\Factory\Dynamic\Developer->create() called at [lib/internal/Magento/Framework/ObjectManager/ObjectManager.php:56]
#12 Magento\Framework\ObjectManager\ObjectManager->create() called at [lib/internal/Magento/Framework/Pricing/Price/Factory.php:47]
#13 Magento\Framework\Pricing\Price\Factory->create() called at [lib/internal/Magento/Framework/Pricing/Price/Collection.php:138]
#14 Magento\Framework\Pricing\Price\Collection->get() called at [lib/internal/Magento/Framework/Pricing/Price/Collection.php:93]
#15 Magento\Framework\Pricing\Price\Collection->current() called at [app/code/Magento/Catalog/Pricing/Price/BasePrice.php:31]
#16 Magento\Catalog\Pricing\Price\BasePrice->getValue() called at [app/code/Magento/Catalog/Pricing/Price/FinalPrice.php:44]
#17 Magento\Catalog\Pricing\Price\FinalPrice->getValue() called at [lib/internal/Magento/Framework/Pricing/Price/AbstractPrice.php:100]
#18 Magento\Framework\Pricing\Price\AbstractPrice->getAmount() called at [app/code/Magento/Catalog/Pricing/Render/FinalPriceBox.php:156]
#19 Magento\Catalog\Pricing\Render\FinalPriceBox->hasSpecialPrice() called at [generated/code/Magento/Catalog/Pricing/Render/FinalPriceBox/Interceptor.php:37]
#20 Magento\Catalog\Pricing\Render\FinalPriceBox\Interceptor->hasSpecialPrice() called at [app/code/Magento/Catalog/view/base/templates/product/price/final_price.phtml:24]
#21 include() called at [lib/internal/Magento/Framework/View/TemplateEngine/Php.php:59]
#22 Magento\Framework\View\TemplateEngine\Php->render() called at [lib/internal/Magento/Framework/View/Element/Template.php:270]
#23 Magento\Framework\View\Element\Template->fetchView() called at [generated/code/Magento/Catalog/Pricing/Render/FinalPriceBox/Interceptor.php:271]
#24 Magento\Catalog\Pricing\Render\FinalPriceBox\Interceptor->fetchView() called at [lib/internal/Magento/Framework/View/Element/Template.php:300]
#25 Magento\Framework\View\Element\Template->_toHtml() called at [lib/internal/Magento/Framework/Pricing/Render/PriceBox.php:69]
#26 Magento\Framework\Pricing\Render\PriceBox->_toHtml() called at [app/code/Magento/Catalog/Pricing/Render/FinalPriceBox.php:71]
#27 Magento\Catalog\Pricing\Render\FinalPriceBox->_toHtml() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1097]
#28 Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element{closure}() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1101]
#29 Magento\Framework\View\Element\AbstractBlock->_loadCache() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:674]
#30 Magento\Framework\View\Element\AbstractBlock->toHtml() called at [generated/code/Magento/Catalog/Pricing/Render/FinalPriceBox/Interceptor.php:583]
#31 Magento\Catalog\Pricing\Render\FinalPriceBox\Interceptor->toHtml() called at [lib/internal/Magento/Framework/Pricing/Render.php:97]
#32 Magento\Framework\Pricing\Render->render() called at [app/code/Magento/Catalog/Block/Product/ListProduct.php:398]
#33 Magento\Catalog\Block\Product\ListProduct->getProductPrice() called at [generated/code/Magento/Catalog/Block/Product/ListProduct/Interceptor.php:180]
#34 Magento\Catalog\Block\Product\ListProduct\Interceptor->getProductPrice() called at [app/code/Magento/Catalog/view/frontend/templates/product/list.phtml:72]
#35 include() called at [lib/internal/Magento/Framework/View/TemplateEngine/Php.php:59]
#36 Magento\Framework\View\TemplateEngine\Php->render() called at [lib/internal/Magento/Framework/View/Element/Template.php:270]
#37 Magento\Framework\View\Element\Template->fetchView() called at [generated/code/Magento/Catalog/Block/Product/ListProduct/Interceptor.php:557]
#38 Magento\Catalog\Block\Product\ListProduct\Interceptor->fetchView() called at [lib/internal/Magento/Framework/View/Element/Template.php:300]
#39 Magento\Framework\View\Element\Template->_toHtml() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1097]
#40 Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element{closure}() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1101]
#41 Magento\Framework\View\Element\AbstractBlock->_loadCache() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:674]
#42 Magento\Framework\View\Element\AbstractBlock->toHtml() called at [generated/code/Magento/Catalog/Block/Product/ListProduct/Interceptor.php:882]
#43 Magento\Catalog\Block\Product\ListProduct\Interceptor->toHtml() called at [lib/internal/Magento/Framework/View/Layout.php:557]
#44 Magento\Framework\View\Layout->_renderBlock() called at [lib/internal/Magento/Framework/View/Layout.php:533]
#45 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#46 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#47 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#48 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:521]
#49 Magento\Framework\View\Element\AbstractBlock->getChildHtml() called at [app/code/Magento/Catalog/Block/Category/View.php:100]
#50 Magento\Catalog\Block\Category\View->getProductListHtml() called at [app/code/Magento/Catalog/view/frontend/templates/category/products.phtml:18]
#51 include() called at [lib/internal/Magento/Framework/View/TemplateEngine/Php.php:59]
#52 Magento\Framework\View\TemplateEngine\Php->render() called at [lib/internal/Magento/Framework/View/Element/Template.php:270]
#53 Magento\Framework\View\Element\Template->fetchView() called at [lib/internal/Magento/Framework/View/Element/Template.php:300]
#54 Magento\Framework\View\Element\Template->_toHtml() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1097]
#55 Magento\Framework\View\Element\AbstractBlock->Magento\Framework\View\Element{closure}() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:1101]
#56 Magento\Framework\View\Element\AbstractBlock->_loadCache() called at [lib/internal/Magento/Framework/View/Element/AbstractBlock.php:674]
#57 Magento\Framework\View\Element\AbstractBlock->toHtml() called at [lib/internal/Magento/Framework/View/Layout.php:557]
#58 Magento\Framework\View\Layout->_renderBlock() called at [lib/internal/Magento/Framework/View/Layout.php:533]
#59 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#60 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#61 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#62 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#63 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#64 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#65 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#66 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#67 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#68 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#69 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#70 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#71 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#72 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#73 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#74 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#75 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#76 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#77 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#78 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#79 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#80 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#81 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#82 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#83 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#84 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#85 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#86 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#87 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:585]
#88 Magento\Framework\View\Layout->_renderContainer() called at [lib/internal/Magento/Framework/View/Layout.php:535]
#89 Magento\Framework\View\Layout->renderNonCachedElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:206]
#90 Magento\Framework\View\Layout\Interceptor->renderNonCachedElement() called at [lib/internal/Magento/Framework/View/Layout.php:488]
#91 Magento\Framework\View\Layout->renderElement() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:193]
#92 Magento\Framework\View\Layout\Interceptor->renderElement() called at [lib/internal/Magento/Framework/View/Layout.php:954]
#93 Magento\Framework\View\Layout->getOutput() called at [lib/internal/Magento/Framework/Interception/Interceptor.php:58]
#94 Magento\Framework\View\Layout\Interceptor->___callParent() called at https://github.com/magento/magento2/pull/22197[lib/internal/Magento/Framework/Interception/Interceptor.php:138]
#95 Magento\Framework\View\Layout\Interceptor->Magento\Framework\Interception{closure}() called at [lib/internal/Magento/Framework/Interception/Interceptor.php:153]
#96 Magento\Framework\View\Layout\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/View/Layout/Interceptor.php:494]
#97 Magento\Framework\View\Layout\Interceptor->getOutput() called at [lib/internal/Magento/Framework/View/Result/Page.php:257]
#98 Magento\Framework\View\Result\Page->render() called at [lib/internal/Magento/Framework/View/Result/Layout.php:170]
#99 Magento\Framework\View\Result\Layout->renderResult() called at [lib/internal/Magento/Framework/Interception/Interceptor.php:58]
#100 Magento\Framework\View\Result\Page\Interceptor->___callParent() called at [lib/internal/Magento/Framework/Interception/Interceptor.php:138]
#101 Magento\Framework\View\Result\Page\Interceptor->Magento\Framework\Interception{closure}() called at [lib/internal/Magento/Framework/Interception/Interceptor.php:153]
#102 Magento\Framework\View\Result\Page\Interceptor->___callPlugins() called at [generated/code/Magento/Framework/View/Result/Page/Interceptor.php:130]
#103 Magento\Framework\View\Result\Page\Interceptor->renderResult() called at [lib/internal/Magento/Framework/App/Http.php:140]
#104 Magento\Framework\App\Http->launch() called at [generated/code/Magento/Framework/App/Http/Interceptor.php:24]
#105 Magento\Framework\App\Http\Interceptor->launch() called at [lib/internal/Magento/Framework/App/Bootstrap.php:260]
#106 Magento\Framework\App\Bootstrap->run() called at [pub/index.php:40]

Observations

Module Magento_Msrp doesn't work with both modules Magento_MsrpConfigurableProduct and Magento_MsrpGroupedProduct disabled

Module Magento_Msrp is supposed to receive the arguments from Magento_MsrpConfigurableProduct or Magento_MsrpGroupedProduct according to:

app/code/Magento/MsrpConfigurableProduct/etc/di.xml

app/code/Magento/MsrpGroupedProduct/etc/di.xml

Pull request (possible solution)

#22197
@m2-assistant
Copy link

m2-assistant bot commented Apr 7, 2019 •
edited by lfluvisotto
Loading

Hi @lfluvisotto. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@lfluvisotto do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Apr 7, 2019
@lfluvisotto lfluvisotto mentioned this issue Apr 7, 2019
Closed
4 tasks
@lfluvisotto
Copy link
Contributor Author

In vanilla Magento instance is possible to simulate the issue if it's possible to disable the modules Magento_MsrpConfigurableProduct and Magento_MsrpGroupedProduct

@hostep hostep mentioned this issue Apr 7, 2019
Closed
@davidverholen davidverholen self-assigned this Apr 7, 2019
@m2-assistant
Copy link

m2-assistant bot commented Apr 7, 2019 •
edited by davidverholen
Loading

Hi @davidverholen. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.3-develop branch

    Details- Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Verify that the issue is reproducible on 2.2-develop branch.

    Details- Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

  • 6. Add label Issue: Confirmed once verification is complete.

  • 7. Make sure that automatic system confirms that report has been added to the backlog.

@davidverholen davidverholen added Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Component: Msrp Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release labels Apr 7, 2019
@magento-engcom-team magento-engcom-team added the Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development label Apr 7, 2019
@magento-engcom-team
Copy link
Contributor

✅ Confirmed by @davidverholen
Thank you for verifying the issue. Based on the provided information internal tickets MAGETWO-99082 were created

Issue Available: @davidverholen, You will be automatically unassigned. Contributors/Maintainers can claim this issue to continue. To reclaim and continue work, reassign the ticket to yourself.

@ghost ghost assigned lfluvisotto Apr 7, 2019
@lfluvisotto lfluvisotto mentioned this issue Apr 8, 2019
Merged
4 tasks
@TomashKhamlai TomashKhamlai mentioned this issue Apr 11, 2019
Merged
@magento-engcom-team
Copy link
Contributor

Hi @lfluvisotto, @lfluvisotto.

Thank you for your report and collaboration!

The issue was fixed by Magento team.

The fix will be available with the upcoming 2.3.3 release.

@magento-engcom-team magento-engcom-team added the Fixed in 2.3.x The issue has been fixed in 2.3 release line label Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lfluvisotto lfluvisotto

Labels
Component: Msrp Fixed in 2.3.x The issue has been fixed in 2.3 release line Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lfluvisotto @davidverholen @magento-engcom-team