-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added logging of executed setup files #43
Conversation
@amenk Logging is such kind of a feature, which can be enhanced infinitely, for instance, by adding logging to more and more places of the system. However, it's pretty hard to decide which actions in the system should and which shouldn't be logged. Such events as execution of DB install/upgrade scripts happen extremely rate -- during the application installation and upgrading between versions only. In addition, logging itself is pure developer-oriented feature with no business value added to it. Taking in consideration all the above, closing the ticket as "won't implement". |
In my opinion there can't be to much logging, only to less. This log would be useful - not only for a developer but also for a shop owner who conducts an update himself. And what is wrong with developer-oriented features? If the developer is happy, the customer is happy. |
By accident I added to many commits to this pullrequest - only "aa5be36" should be included. |
@amenk The logging has been added, but with modified messages:
|
Great, thanks! |
Glad to see this was implemented! |
* Implemented encryption of the credit card name and expiration date for the payment method "Credit Card (saved)" * Implemented console utility `dev/tools/migration/get_aliases_map.php`, which generates map file "M1 class alias" to "M2 class name" * Implemented automatic data upgrades for replacing "M1 class aliases" to "M2 class names" in a database * Implemented recursive `chmod` in the library class `Varien_Io_File` * Improved verbosity of the library class `Magento_Shell` * Migrated client-side translation mechanism to jQuery * Performance tests: * Improved assertion for number of created orders for the checkout performance testing scenario * Reverted the feature of specifying PHP scenarios to be executed before and after a JMeter scenario * Implemented validation for the number of created orders as a part of the JMeter scenario * Implemented the "Admin Login" user activity as a separate file to be reused in the performance testing scenarios * Implemented fixture of 100k customers for the performance tests * Implemented fixture of 100k products for the performance tests * Enhanced module `Mage_ImportExport` in order to utilize it for the fixture implementation * Implemented back-end performance testing scenario, which covers Dashboard, Manage Products, Manage Customers pages * Fixes: * Fixed Magento console installer to enable write permission recursively to the `var` directory * Fixed performance tests to enable write permission recursively to the `var` directory * Fixed integration test `Mage_Adminhtml_Model_System_Config_Source_Admin_PageTest::testToOptionArray` to not produce "Warning: DOMDocument::loadHTML(): htmlParseEntityRef: expecting ';' in Entity" in the developer mode * GitHub requests: * [#43](#43) -- implemented logging of executed setup files * [#44](#44) * Implemented support of writing logs into wrappers (for example, `php://output`) * Enforced a log writer model to be an instance of `Zend_Log_Writer_Stream` * [#49](#49) * Fixed sorting of totals according to "before" and "after" properties * Introduced `Magento_Data_Graph` library class and utilized it for finding cycles in "before" and "after" declarations * Implemented tests for totals sorting including the ambiguous cases
[Github] Merge public Github commits
MAGETWO-66666: Adding a product to cart from category page with an ex…
- Replace deprecated blur() function
No description provided.