Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't encode email subject if not necessary. #45

Closed
colinmollenhour opened this issue Jul 18, 2012 · 1 comment
Closed

Don't encode email subject if not necessary. #45

colinmollenhour opened this issue Jul 18, 2012 · 1 comment

Comments

@colinmollenhour
Copy link

A couple reasons:

  1. It makes it hard to read when debugging, or if viewing the raw email headers, or in some client that is not smart enough to decode the subject (yes, there are a few).
  2. I've seen a spamassassin rule that dings an email if the subject is unnecessarily encoded.

So the solution would be to use a method to detect if the subject has non-ascii characters and not encode it if it doesn't.

@magento-team
Copy link
Contributor

@colinmollenhour
Message subject is encoded in accordance with the RFC 2047 section 5 "Use of encoded-words in message headers":

An 'encoded-word' may appear in a message header or body part header
according to the following rules:

(1) An 'encoded-word' may replace a 'text' token (as defined by RFC 822)
in any Subject or Comments header field, any extension message
header field, or any MIME body part field for which the field body
is defined as '*text'.

SpamAssassin rule, which dings an email if the subject is unnecessarily encoded, does not comply with the RFC 2047 section 6.1 "Recognition of 'encoded-word's in message headers".

It's essential for debugging to access data "as is", whether it's encoded or not.

Closing the ticket as "won't fix".

tang-yu pushed a commit that referenced this issue Jan 23, 2015
[Fearless-Kiwis] Sprint 38 bug fixes
@stevieyu stevieyu mentioned this issue Apr 3, 2015
okorshenko pushed a commit that referenced this issue Oct 28, 2015
@FabXav FabXav mentioned this issue Oct 11, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants