Prevent dashboard from generating a bunch of reports when Google Charts API is unavailable #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts API is unavailable
|
Important: The Image Charts portion of Google Chart Tools has been officially deprecated as of April 20, 2012. It will continue to work as per our deprecation policy. |
|
@kirmorozov where did you find the information about deprecated API? |
|
https://developers.google.com/chart/image/ P.S. Don't hide errors. fix them |
|
@Zifius
We chose not to bother implementing a "stub" image for now... |
|
Thank you for accepting my contribution! Any chance to cherry-pick it to Magento 1.x? |
|
We have no plans for porting it to Magento 1.x, sorry. You can apply it to your copy of Magento 1.x in a form of local class override. |
|
That's fine, this is what I already did (sort of). Thanks again for accepting it! |
magento-team
added a commit
that referenced
this pull request
Nov 12, 2012
* Framework changes
* Added dependency injection of framework capability
* Adopted Zend\Di component of Zend Framework 2 library
* Implemented object manager in Magento application
* Refactored multiple base classes to dependency injection principle (dependencies are declared in constructor)
* Themes/View
* Implemented storing themes registry in database, basic CRUD of themes, automatic registration of themes in database from file system out of the box
* Renamed `Mage_Core_Model_Layout_Update` into `Mage_Core_Model_Layout_Merge`, the former becomes an entity domain model. Similar changes with `Mage_Core_Model_Resource_Layout` -> `Mage_Core_Model_Resource_Layout_Update`, `Mage_Core_Model_Layout_Data` -> `Mage_Core_Model_Layout_Update`
* Performance tests
* Improved indexers running script `dev/shell/indexer.php` to return appropriate exit code upon success/failure
* Implemented running the same performance scenario file with different parameters
* Slightly refactored framework class `Magento_Performance_Testsuite_Optimizer` for better visibility of algorithm
* Visual design editor
* Added ability to remove elements in editor UI
* Revised history of changes VDE toolbar and algorithm of "compacting" operations (moving, removing elements) as a layout update XML
* Added selection of themes to VDE launcher page
* Refactored JavaScript of some UI elements to jQuery:
* "Simple" and "configurable" product view pages
* "Create Account" page
* "Shopping Cart" page
* CAPTCHA
* Newsletter subscription
* Tax management UX improvements
* Split Basic and Advanced Settings for Tax Rule Management UI
* Moved the Import/Export functionality to Tax Rate page
* Moved Tax menu to System from Sales
* Implemented the editable multiselect JavaScript component
* Added mentioning sitemap in `robots.txt` after generation
* Removed creation of DB backup in integration testing framework
* Fixed logic of order of loading ACL resources in backend
* Fixed JavaScript error during installation when one of files in `pub/media` is not writable
* Fixed structure of legacy test fixtures that allowed ambiguous keys in declaration
* Fixed inability to restore admin password when CAPTCHA is enabled
* Various minor UX fixes (labels, buttons, redirects, etc...)
* GitHub requests:
* [#59](#59) -- implemented handling of unexpected situations in admin/dashboard/tunnel action
* [#66](#66)
* refactored ImageMagick adapter unit test to avoid system operation
* simplified unit testing framework -- removed unused classes, simplified handling logic of directory `dev/tests/unit/tmp` and removed it from VCS
* [#73](#73), [#74](#74) -- fixes in docblock tags
* [#75](#75), [#96](#96) -- fixed translation module contexts in a few places
* [#80](#80) -- fixed some runtime errors in import/export module
* [#81](#81) -- removed usage of "remove" directive in places where it is overridden by setting root template anyway
* [#87](#87) -- changed paths of files to include from relative into absolute in `dev/shell/indexer.php` and `log.php`
* [#88](#88) -- provided comments for values that can be configured in `app/etc/local.xml` file
* [#90](#90) -- slightly optimized logic of implementation of loading configurable product attributes
vpelipenko
added a commit
that referenced
this pull request
Jan 30, 2015
MAGETWO-31078: M2 GitHub Update (version 0.42.0-beta5) & Public pull requests
vpelipenko
added a commit
that referenced
this pull request
Jan 30, 2015
MAGETWO-31078: M2 GitHub Update (version 0.42.0-beta5) & Public pull requests
Closed
Closed
This was referenced Nov 22, 2015
ghost
mentioned this pull request
ghost
mentioned this pull request
magento-engcom-team
pushed a commit
that referenced
this pull request
Aug 17, 2018
Merge 2.3-develop to EPAM-PR-3
5 tasks
ghost
mentioned this pull request
1 task
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log as an exception instead