-
Notifications
You must be signed in to change notification settings - Fork 155
Shopping cart grand total and taxes coverage #441
Conversation
0f0637b
to
4b89ee0
Compare
# Conflicts: # app/code/Magento/QuoteGraphQl/etc/schema.graphqls
@rogyar, do you know anything about?
It looks like not connected with your pull request, however the defect was found on this branch. |
Hi @TomashKhamlai. Didn't get something like this. Please, try the recent version, I've merged the mainline commits to the current branch. |
Got this: {
"data" : {
"cart" : {
"prices" : {
"grand_total" : {
"value" : 10.83,
"currency" : "USD"
},
"subtotal_excluding_tax" : {
"value" : 10,
"currency" : "USD"
},
"subtotal_including_tax" : {
"currency" : "USD",
"value" : 10.83
},
"applied_taxes" : [
{
"amount" : {
"value" : 0.83,
"currency" : "USD"
},
"label" : "US-CA-*-Rate 1"
}
],
"subtotal_with_discount_excluding_tax" : {
"value" : 10,
"currency" : "USD"
}
}
}
}
} I am not sure but I it looks like value is cropped. I believe that value should have format {integer number}{localized decimal sign}{fraction according to currency}. Pay attention that some currency has 3 positions after decimal sign and if I not mistaken some of the currency do not have fraction. In USD the value should be: |
Hi @rogyar, thank you for your contribution! |
Documented as part of magento/devdocs#4502 |
Description (*)
This PR introduces a possibility to view cart totals as well as taxes applied within scope of the current shopping cart
Fixed Issues (if relevant)
Manual testing scenarios (*)