Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techouse
changed the title
|
I have tested the changes in a Flutter app and so far so good, but more tests are needed to make sure everything works as it should. Some of the changes, i.e. super initializers, require Dart 2.17.0. Can a few of you guys check out this branch and run a few tests with it? |
techouse
changed the title
|
Tests are green. And usage is okay. But I'm still thinking that 2.17 maybe too high for this lib... But on the other hand it is better thing to use 2.17 dart. :) |
|
@JEuler Agreed. A bump to Dart 2.17 is significant and should require a major version change of this lib. |
JEuler
approved these changes
Sep 5, 2022
|
@techouse Whoops, could you please resolve the conflicts? |
Done 😇 |
JEuler
pushed a commit
that referenced
this pull request
Oct 8, 2022
JEuler
added a commit
that referenced
this pull request
Oct 15, 2022
* Fix Header Option Casting (#260) Co-authored-by: Ivan Terekhin <[email protected]> * Fix for #259 (#263) * 4.0.1 fixes (#264) * analyzer dependency upgraded (#296) * fix(generator): fix PartValueFile value not nullable if arg is (#288) (#293) * Chopper generator release 4.0.2 (#297) * fix: fix this.body cast of null value when response body is null (#291) (#292) * Interpolation fixes (#275) * encodeQueryComponent now encodeComponent (#278) * Prevent double call on token refreshment (#276) * Fixes for #309 #308 (#310) * Remove new keyword from interceptors.md (#312) * Analyzer upgrade (#320) Co-authored-by: István Juhos <[email protected]> * Add unnecessary_brace_in_string_interps to lint ignores (#317) * Extend pragma to quiet the linter (#318) Co-authored-by: Ivan Terekhin <[email protected]> * Fix converter getting called twice if using an authenticator with a JsonConverter on the request (#324) * migrate example to nullsafety (#331) * Resolve problem in main_json_serializable example (#328) * Add @FiledMap @PartMap @PartFileMap (#335) Co-authored-by: Meysam Karimi <[email protected]> * Upgrade of analyzer (#340) * Fix nullable QueryMap fails to compile (#344) * Change return type of decodeJson to FutureOr in order to be able to support compute() (#345) * Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml (#349) * Version bumped for release (#352) * Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement (#354) * [chopper_generator] Update analyzer to ^4.4.0 and code_builde to ^4.3.0 and migrate deprecated code (#358) * Add Makefiles to streamline development (#357) * Add Bug Report Github issue template (#359) * [chopper_generator] Add types to the generated variables (#360) * Provide an example using an Isolate Worker Pool with Squadron (#361) * mapToQuery changes (#364) * Version bumped / changelog update (#367) * Request extends http.BaseRequest (#370) * Exclude null query vars by default and add new @method annotation includeNullQueryVars (#372) * 5.1.0 (dev) (#373) Co-authored-by: Ivan Terekhin <[email protected]> Co-authored-by: Youssef Raafat <[email protected]> Co-authored-by: luis901101 <[email protected]> Co-authored-by: melvspace <[email protected]> Co-authored-by: Michal Šrůtek <[email protected]> Co-authored-by: István Juhos <[email protected]> Co-authored-by: Andre <[email protected]> Co-authored-by: John Wimer <[email protected]> Co-authored-by: Max Röhrl <[email protected]> Co-authored-by: ipcjs <[email protected]> Co-authored-by: ibadin <[email protected]> Co-authored-by: Meysam Karimi <[email protected]> Co-authored-by: Meysam Karimi <[email protected]> Co-authored-by: Klemen Tusar <[email protected]> Co-authored-by: Klemen Tusar <[email protected]> Co-authored-by: Ivan Terekhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dart suggests migrating from package:pedantic so I've taken the liberty to re-format the packages and examples.
In the process, I've switched from
pedantictolints: ^2.0.0, with the recommended lints enables, which require Dart SDK 2.17.0, thus I have bumped the minimum SDK version to2.17.0.If you believe this SDK version is too high I can downgrade to
lints: ^1.0.0and revert to the previous minimum SDK of2.12.0.As this is more or less a cosmetic PR further reviews and/or scrutiny will be necessary.