Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Analyzer upgrade #320

Merged
merged 9 commits into from
Jan 16, 2022
Merged

Analyzer upgrade #320

merged 9 commits into from
Jan 16, 2022

Conversation

JEuler
Copy link
Collaborator

@JEuler JEuler commented Jan 10, 2022

No description provided.

@JEuler JEuler requested a review from stewemetal January 10, 2022 19:47
@stewemetal
Copy link
Collaborator

The PR itself is OK of course, but the analyzer build step is failing 😕

@JEuler
Copy link
Collaborator Author

JEuler commented Jan 11, 2022

Yeah, we need to rework actions. Let's go in this PR.

@stewemetal
Regenerate GitHub CI config with mono_repo; Replace dartfmt with dart…
7e82cd4 
… format; Add minimalistic CI setup documentation
@stewemetal stewemetal mentioned this pull request Jan 14, 2022
Closed
@stewemetal
Copy link
Collaborator

stewemetal commented Jan 14, 2022 •
edited
Loading

@JEuler CI is green, we're ready to merge it 💪 Please have a look and decide if it's OK.

This was referenced Jan 14, 2022
Merged
Merged
@JEuler
Copy link
Collaborator Author

JEuler commented Jan 15, 2022

Awesome job! Thank you! One question:
expect(converted is Response, isTrue); - why such checks are removed? :)

@stewemetal
Copy link
Collaborator

stewemetal commented Jan 15, 2022 •
edited
Loading

Awesome job! Thank you! One question: expect(converted is Response, isTrue); - why such checks are removed? :)

Because - as the Analyzer correctly pointed it out -, since converted is always a Response, the check does not provide any added value to the test.

jsonConverter.convertResponse<K, V>(res) is type-safe, at least in a way that it always returns a Response.

@JEuler
Copy link
Collaborator Author

JEuler commented Jan 16, 2022

Cooool!

@JEuler JEuler merged commit d4dab0d into develop Jan 16, 2022
@JEuler JEuler deleted the analyzer-upgrade branch January 16, 2022 06:21
JEuler added a commit that referenced this pull request Oct 15, 2022
@JEuler @yousinix
@luis901101 @rIIh @michalsrutek @stewemetal @pingbird @vipw @maxroehrl @ipcjs @ibadin @meysam1717 @mysmartapply @techouse
Release 5.1.0 (master) (#374)
0e5f986 
* Fix Header Option Casting (#260)

Co-authored-by: Ivan Terekhin <[email protected]>

* Fix for #259 (#263)

* 4.0.1 fixes (#264)

* analyzer dependency upgraded (#296)

* fix(generator): fix PartValueFile value not nullable if arg is (#288) (#293)

* Chopper generator release 4.0.2 (#297)

* fix: fix this.body cast of null value when response body is null (#291) (#292)

* Interpolation fixes (#275)

* encodeQueryComponent now encodeComponent (#278)

* Prevent double call on token refreshment (#276)

* Fixes for #309 #308 (#310)

* Remove new keyword from interceptors.md (#312)

* Analyzer upgrade (#320)

Co-authored-by: István Juhos <[email protected]>

* Add unnecessary_brace_in_string_interps to lint ignores (#317)

* Extend pragma to quiet the linter (#318)

Co-authored-by: Ivan Terekhin <[email protected]>

* Fix converter getting called twice if using an authenticator with a JsonConverter on the request (#324)

* migrate example to nullsafety (#331)

* Resolve problem in main_json_serializable example (#328)

* Add @FiledMap @PartMap @PartFileMap (#335)

Co-authored-by: Meysam Karimi <[email protected]>

* Upgrade of analyzer (#340)

* Fix nullable QueryMap fails to compile (#344)

* Change return type of decodeJson to FutureOr in order to be able to support compute() (#345)

* Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml (#349)

* Version bumped for release (#352)

* Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement (#354)

* [chopper_generator] Update analyzer to ^4.4.0 and code_builde to ^4.3.0 and migrate deprecated code (#358)

* Add Makefiles to streamline development (#357)

* Add Bug Report Github issue template (#359)

* [chopper_generator] Add types to the generated variables (#360)

* Provide an example using an Isolate Worker Pool with Squadron (#361)

* mapToQuery changes (#364)

* Version bumped / changelog update (#367)

* Request extends http.BaseRequest (#370)

* Exclude null query vars by default and add new @method annotation includeNullQueryVars (#372)

* 5.1.0 (dev) (#373)

Co-authored-by: Ivan Terekhin <[email protected]>

Co-authored-by: Youssef Raafat <[email protected]>
Co-authored-by: luis901101 <[email protected]>
Co-authored-by: melvspace <[email protected]>
Co-authored-by: Michal Šrůtek <[email protected]>
Co-authored-by: István Juhos <[email protected]>
Co-authored-by: Andre <[email protected]>
Co-authored-by: John Wimer <[email protected]>
Co-authored-by: Max Röhrl <[email protected]>
Co-authored-by: ipcjs <[email protected]>
Co-authored-by: ibadin <[email protected]>
Co-authored-by: Meysam Karimi <[email protected]>
Co-authored-by: Meysam Karimi <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: Ivan Terekhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewemetal stewemetal stewemetal approved these changes

Assignees

@JEuler JEuler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JEuler @stewemetal