RequestConverter and ResponseConverter not propagated once again after Authenticator.authenticate gives updated request #309
Comments
|
Verified Fix Thanks for the update |
|
No, thank you! 🍺 |
JEuler
added a commit
that referenced
this issue
Oct 15, 2022
* Fix Header Option Casting (#260) Co-authored-by: Ivan Terekhin <[email protected]> * Fix for #259 (#263) * 4.0.1 fixes (#264) * analyzer dependency upgraded (#296) * fix(generator): fix PartValueFile value not nullable if arg is (#288) (#293) * Chopper generator release 4.0.2 (#297) * fix: fix this.body cast of null value when response body is null (#291) (#292) * Interpolation fixes (#275) * encodeQueryComponent now encodeComponent (#278) * Prevent double call on token refreshment (#276) * Fixes for #309 #308 (#310) * Remove new keyword from interceptors.md (#312) * Analyzer upgrade (#320) Co-authored-by: István Juhos <[email protected]> * Add unnecessary_brace_in_string_interps to lint ignores (#317) * Extend pragma to quiet the linter (#318) Co-authored-by: Ivan Terekhin <[email protected]> * Fix converter getting called twice if using an authenticator with a JsonConverter on the request (#324) * migrate example to nullsafety (#331) * Resolve problem in main_json_serializable example (#328) * Add @FiledMap @PartMap @PartFileMap (#335) Co-authored-by: Meysam Karimi <[email protected]> * Upgrade of analyzer (#340) * Fix nullable QueryMap fails to compile (#344) * Change return type of decodeJson to FutureOr in order to be able to support compute() (#345) * Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml (#349) * Version bumped for release (#352) * Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement (#354) * [chopper_generator] Update analyzer to ^4.4.0 and code_builde to ^4.3.0 and migrate deprecated code (#358) * Add Makefiles to streamline development (#357) * Add Bug Report Github issue template (#359) * [chopper_generator] Add types to the generated variables (#360) * Provide an example using an Isolate Worker Pool with Squadron (#361) * mapToQuery changes (#364) * Version bumped / changelog update (#367) * Request extends http.BaseRequest (#370) * Exclude null query vars by default and add new @method annotation includeNullQueryVars (#372) * 5.1.0 (dev) (#373) Co-authored-by: Ivan Terekhin <[email protected]> Co-authored-by: Youssef Raafat <[email protected]> Co-authored-by: luis901101 <[email protected]> Co-authored-by: melvspace <[email protected]> Co-authored-by: Michal Šrůtek <[email protected]> Co-authored-by: István Juhos <[email protected]> Co-authored-by: Andre <[email protected]> Co-authored-by: John Wimer <[email protected]> Co-authored-by: Max Röhrl <[email protected]> Co-authored-by: ipcjs <[email protected]> Co-authored-by: ibadin <[email protected]> Co-authored-by: Meysam Karimi <[email protected]> Co-authored-by: Meysam Karimi <[email protected]> Co-authored-by: Klemen Tusar <[email protected]> Co-authored-by: Klemen Tusar <[email protected]> Co-authored-by: Ivan Terekhin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello,
After getting an updated request and calling send on the updated Request like below,
line number 317
res = await send<BodyType, InnerType>(updatedRequest);The Request/Response type converters are not further propagated and its causing type mismatch error when refreshing the token and calling the same request again using the Authenticator.
To fix it,
line number 317 can be updated as below
res = await send<BodyType, InnerType>(updatedRequest, requestConverter: requestConverter, responseConverter: responseConverter,);Please consider to include this in the next pub dev version
Thanks
The text was updated successfully, but these errors were encountered: