Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Request instance is passed to Authenticator.authenticate method #308

Closed
imatok opened this issue Nov 22, 2021 · 5 comments · Fixed by #324
Closed

Wrong Request instance is passed to Authenticator.authenticate method #308

imatok opened this issue Nov 22, 2021 · 5 comments · Fixed by #324

Comments

@imatok
Copy link

imatok commented Nov 22, 2021

Hello,

this is really a small one that bugs me right now :).
Inside send method, Authenticator gets vanilla Request passed that hasn't been converted nor intercepted.
I'm adding some custom headers via RequestInterceptor that get stripped when Authenticator must do his magic, so I cannot re-send the updated request.

Future<Response<BodyType>> send<BodyType, InnerType>(
    Request request, {
    ConvertRequest? requestConverter,
    ConvertResponse? responseConverter,
  }) async {
    var req = await _handleRequestConverter(request, requestConverter);
    req = await _interceptRequest(req);
    _requestController.add(req);
...
    if (authenticator != null) {
      var updatedRequest = await authenticator!.authenticate(request, res);
...

To fix it, line 314 should be:

     var updatedRequest = await authenticator!.authenticate(req, res);

Hope this will be on pub.dev soon ;)

BR

@JEuler
Copy link
Collaborator

JEuler commented Dec 1, 2021

#310

Sorry for delay, will try to publish it soon

JEuler added a commit that referenced this issue Dec 7, 2021
@JEuler
Copy link
Collaborator

JEuler commented Dec 9, 2021

https://pub.dev/packages/chopper

@JEuler
Copy link
Collaborator

JEuler commented Dec 14, 2021

@imatok Should I close it? :)

@imatok
Copy link
Author

imatok commented Dec 14, 2021

Thanks for releasing it. :)

@imatok imatok closed this as completed Dec 14, 2021
@JEuler
Copy link
Collaborator

JEuler commented Dec 14, 2021

Thank you! 🍺

JEuler added a commit that referenced this issue Oct 8, 2022
JEuler added a commit that referenced this issue Oct 15, 2022
* Fix Header Option Casting (#260)

Co-authored-by: Ivan Terekhin <[email protected]>

* Fix for #259 (#263)

* 4.0.1 fixes (#264)

* analyzer dependency upgraded (#296)

* fix(generator): fix PartValueFile value not nullable if arg is (#288) (#293)

* Chopper generator release 4.0.2 (#297)

* fix: fix this.body cast of null value when response body is null (#291) (#292)

* Interpolation fixes (#275)

* encodeQueryComponent now encodeComponent (#278)

* Prevent double call on token refreshment (#276)

* Fixes for #309 #308 (#310)

* Remove new keyword from interceptors.md (#312)

* Analyzer upgrade (#320)

Co-authored-by: István Juhos <[email protected]>

* Add unnecessary_brace_in_string_interps to lint ignores (#317)

* Extend pragma to quiet the linter (#318)

Co-authored-by: Ivan Terekhin <[email protected]>

* Fix converter getting called twice if using an authenticator with a JsonConverter on the request (#324)

* migrate example to nullsafety (#331)

* Resolve problem in main_json_serializable example (#328)

* Add @FiledMap @PartMap @PartFileMap (#335)

Co-authored-by: Meysam Karimi <[email protected]>

* Upgrade of analyzer (#340)

* Fix nullable QueryMap fails to compile (#344)

* Change return type of decodeJson to FutureOr in order to be able to support compute() (#345)

* Migrate from pedantic to lints ^2.0.0 with lints/recommended.yaml (#349)

* Version bumped for release (#352)

* Revert analyzer to ^4.1.0 and silence linters for Element.enclosingElement (#354)

* [chopper_generator] Update analyzer to ^4.4.0 and code_builde to ^4.3.0 and migrate deprecated code (#358)

* Add Makefiles to streamline development (#357)

* Add Bug Report Github issue template (#359)

* [chopper_generator] Add types to the generated variables (#360)

* Provide an example using an Isolate Worker Pool with Squadron (#361)

* mapToQuery changes (#364)

* Version bumped / changelog update (#367)

* Request extends http.BaseRequest (#370)

* Exclude null query vars by default and add new @method annotation includeNullQueryVars (#372)

* 5.1.0 (dev) (#373)

Co-authored-by: Ivan Terekhin <[email protected]>

Co-authored-by: Youssef Raafat <[email protected]>
Co-authored-by: luis901101 <[email protected]>
Co-authored-by: melvspace <[email protected]>
Co-authored-by: Michal Šrůtek <[email protected]>
Co-authored-by: István Juhos <[email protected]>
Co-authored-by: Andre <[email protected]>
Co-authored-by: John Wimer <[email protected]>
Co-authored-by: Max Röhrl <[email protected]>
Co-authored-by: ipcjs <[email protected]>
Co-authored-by: ibadin <[email protected]>
Co-authored-by: Meysam Karimi <[email protected]>
Co-authored-by: Meysam Karimi <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: Klemen Tusar <[email protected]>
Co-authored-by: Ivan Terekhin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants