Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kfixedgrid from category search modal #9080

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Feb 3, 2022

Summary

Fixes #8988

This PR cleans up the CategorySearchModal implementation in several ways.

  1. Rather than using KFixedGrid (which does not allow for numCols === 1), it uses KGrid
  2. This eliminates the need for some props (that I probably never should have added) also
  3. Removes a file that wasn't being used at all! 🆘
  4. Changes the display of the CategorySearchModal on the Library page to use FullScreenSidePanel on medium screens, per slack discussion.

References

Most of this refactor should result in no changes to the UI, with the exception of the "medium screen" change (#4):

medium-screen-category-search

Reviewer guidance

  • Does the category search work at each screen resolution?
  • Are there any bugs in the layout (overlapping/squished words, etc.)?

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@marcellamaki marcellamaki added the TODO: needs review Waiting for review label Feb 3, 2022
@@ -123,8 +95,8 @@
}

export default {
name: 'CategorySearchModalOptions',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was going to leave a comment here about not doing this because strings - but there are no strings in this component, so I'll leave this comment to preempt any such similar comments!

Copy link
Member

@nucleogenesis nucleogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM.

I tested in browser and it looks good!

One thing - the FullScreenSidePanel that contains the sub-menu on mobile (listing all of the options under headings) - should have the fullScreenSidePanelCloseButton prop set to false. In RTL the back arrow and X sit right next to each other.

image

@nucleogenesis nucleogenesis self-requested a review February 10, 2022 03:58
@marcellamaki
Copy link
Member Author

One thing - the FullScreenSidePanel that contains the sub-menu on mobile (listing all of the options under headings) - should have the fullScreenSidePanelCloseButton prop set to false. In RTL the back arrow and X sit right next to each other.

Good catch. Should be fixed now
rtl-close-button
ltr-close-button-fix

@marcellamaki marcellamaki force-pushed the remove-kfixedgrid-from-category-search-modal branch from 7af0327 to 4b95c42 Compare February 11, 2022 15:57
@sairina sairina mentioned this pull request Feb 15, 2022
9 tasks
@marcellamaki
Copy link
Member Author

Final changes reviewed and ✅ by @radinamatic and @sairina

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Library's category search modal's options' KFixedGrid requires numCols to be greater than 1
3 participants