-
Notifications
You must be signed in to change notification settings - Fork 710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove kfixedgrid from category search modal #9080
Remove kfixedgrid from category search modal #9080
Conversation
@@ -123,8 +95,8 @@ | |||
} | |||
|
|||
export default { | |||
name: 'CategorySearchModalOptions', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was going to leave a comment here about not doing this because strings - but there are no strings in this component, so I'll leave this comment to preempt any such similar comments!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
7af0327
to
4b95c42
Compare
Summary
Fixes #8988
This PR cleans up the
CategorySearchModal
implementation in several ways.KFixedGrid
(which does not allow for numCols === 1), it usesKGrid
CategorySearchModal
on the Library page to useFullScreenSidePanel
on medium screens, per slack discussion.References
Most of this refactor should result in no changes to the UI, with the exception of the "medium screen" change (#4):
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)