Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library's category search modal's options' KFixedGrid requires numCols to be greater than 1 #8988

Closed
sairina opened this issue Jan 11, 2022 · 0 comments · Fixed by #9080
Closed
Assignees
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) TAG: mobile Issues related to responsiveness or touch-screens

Comments

@sairina
Copy link
Contributor

sairina commented Jan 11, 2022

Observed behavior

In the mobile view, when a learner clicks on Filter button to open the side panel overlay, if they click on a category like "School," there is an error message on the console related to KFixedGrid and the numCols prop passed from CategorySearchModal to CategorySearchModalOptions.

The validator for KFixedGrid requires a number between 2 and 12, but the numCols passed to CategorySearchModalOptions is 1.

Screen Shot 2022-01-11 at 2 49 57 PM

Errors and logs

Screen Shot 2022-01-11 at 2 50 37 PM

Expected behavior

No error in console.

User-facing consequences

Unless there is a design change, there are no user-facing consequences.

Steps to reproduce

  1. Sign in as learner on a small mobile
  2. Go to library page
  3. Click on "Filter button"
  4. Click on a category (like, "School")
  5. Check the console in the browser

Context

Chrome
Kolibri 0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) TAG: mobile Issues related to responsiveness or touch-screens
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants