Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internet Explorer - The info side panel is not displayed #9100

Closed
pcenov opened this issue Feb 11, 2022 · 6 comments
Closed

Internet Explorer - The info side panel is not displayed #9100

pcenov opened this issue Feb 11, 2022 · 6 comments
Labels
ie11 Limited to IE11 + Windows app OS: Windows P0 - critical Priority: Release blocker or regression
Milestone

Comments

@pcenov
Copy link
Member

pcenov commented Feb 11, 2022

Observed behavior

The info side panel of a resource is not displayed when I click the info icon of a card at the Library page or at the Bookmarks page while using IE browser.
This issue was initially reported here: #9063

Expected behavior

Fully functional side panel in IE browser.

Steps to reproduce the issue

  1. Install the following build: https://buildkite.com/learningequality/kolibri-windows/builds/3154
  2. Go to the Library/Bookmarks page and click the info icon of a card.

Screenshots

2022-02-11_15-25-53
2022-02-11_16-20-04

Usage Details

Windows 7 and 10, Internet Explorer

@pcenov
Copy link
Member Author

pcenov commented Feb 11, 2022

@radinamatic

@radinamatic
Copy link
Member

I'm able to replicate this in IE11, and apparently the same error happens when user clicks on the View folder resources or View information buttons.

On top of it, after that error occurs, which has no user-facing notification (just the console), the Go back button (top left arrow) does not work, and the user is effectively stuck there with no way to go anywhere, a part from manually editing the URL (if they know how) 😞

View folder resources View information Go back (top left arrow)
Win10 (start)  Running  - Oracle VM VirtualBox_001 Win10 (start)  Running  - Oracle VM VirtualBox_002 Win10 (start)  Running  - Oracle VM VirtualBox_003

@radinamatic radinamatic added this to the 0.15.1 milestone Feb 14, 2022
@radinamatic radinamatic added ie11 Limited to IE11 + Windows app OS: Windows P0 - critical Priority: Release blocker or regression labels Feb 14, 2022
@radinamatic
Copy link
Member

@marcellamaki This looks like P0 (blocker) to me.

@MisRob
Copy link
Member

MisRob commented Feb 14, 2022

Seems to be more important than what I've been working on so I'll check if I can find out something before our US friends get up :)

@MisRob MisRob self-assigned this Feb 14, 2022
MisRob added a commit to MisRob/kolibri that referenced this issue Feb 14, 2022
There was a missing px unit after this.fixedHeaderHeight value
in CSS `calc` which seems to cause the side panel not appear
at all in Internet Explorer. `calc` has been removed here
completely because it's not needed in computed prop.

Fixes learningequality#9100
@MisRob
Copy link
Member

MisRob commented Feb 14, 2022

Made some progress but am not done yet, see #9103. I'm unassigning myself now in case someone would like to pick this up. If I don't see anyone working on this tomorrow morning, I'll finish it.

@MisRob MisRob removed their assignment Feb 14, 2022
MisRob added a commit to MisRob/kolibri that referenced this issue Feb 14, 2022
There was a missing px unit after this.fixedHeaderHeight value
in CSS `calc` which seems to cause the side panel not appear
at all in Internet Explorer. `calc` has been removed completely
because it's not needed for this particular calculation where
both values have the same px unit.

Fixes learningequality#9100
@MisRob
Copy link
Member

MisRob commented Feb 15, 2022

Should be fixed by #9080

cc @marcellamaki @pcenov @radinamatic

@MisRob MisRob closed this as completed Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ie11 Limited to IE11 + Windows app OS: Windows P0 - critical Priority: Release blocker or regression
Projects
None yet
Development

No branches or pull requests

3 participants