First part of the fix for the info side panel not displayed in Internet Explorer #9103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a missing px unit after this.fixedHeaderHeight value in CSS `calc` which seems to cause the side panel not appear at all in Internet Explorer. `calc` has been removed completely because it's not needed for this particular calculation where both values have the same px unit. Fixes learningequality#9100
MisRob
force-pushed
the
side-panel-fix
branch
from
07b9fef to
226c8f1
Compare
|
Closing in favor of #9080, where the problematic calculation has been removed completely as part of a larger refactor and where @marcellamaki also added fixes for buttons positions. Thank you, @marcellamaki, @radinamatic, and @pcenov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the info side panel not displayed in IE after clicking the info button (#9100). See the commit message for an explanation.
However, I tested this fix on the bookmarks page only, and even though the side panel appears now in Internet Explorer as expected for me, there still needs to be some work done. It seems that over time we somehow updated styles related to positioning the close button in the full-screen side panel and after fixing the calculation in this PR, the button seems to be off now in ALL browsers:
(1) When there are some learning activities
(2) No learning activities or when the header slot is empty
Not sure if it happens with production data but in any case
FullScreenSidePanelshould be ready for this situation since the header slot is optional or when learning activities would be missing.I might have also overlooked something and so far was debugging on Browserstack where things were getting quite stuck. Since #9100 seems to be a blocker to the release, I'm opening a draft PR if someone would like to finish this sooner, before I can get to it again.