Develop into central-develop #3156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ads list of screenshots to take from `screenshots.json` file. Added `/data/screenshots` folder and `ghostdriver.log` to `.gitignore` file.
…reenshots from .json file.
Delete used database after run.
…he form, take screenshots between inputs. Make re-usable the reset and delete sqlite database methods. More efficient selenium browsing code by checking if browser's current url is already the same as the `start_url` or if the last user is the same user for the screenshot so no login is needed.
… command to `screenshots.py`.
Change keys on .json for consistency and make these keys constants. Specify field names on the `actions` array - "Explicit is better than implicit."
…nt browser from always logging-in a user.
Needs to be refactored. Probably good to decouple from TestCase framework. Are there other unnecessary parts that could affect performance? Don't want to slow down sphinx build process.
Add two command line options, --output-dir which lets you specify an output directory for the screenshots relative to the project root url, and --from-str so that we can just pass a JSON string to the command (instead of reading from a file). Also added the ability to specify verbosity, namely now -v 0 gives no output (except for some mysterious TestCase stuff???).
Entered some sort of import hell... At least it's possible to invoke the management command by an os.system call, but it's not pretty.
…screenshots on multiple runs
And some other minor changes: * Handle empty arg_str for _parse_nav_steps * In _parse_nav_steps change return type of `args` keyword in order to conform with the invocation in `run` method * Removed _commands_handler as it was rendundant and folded the case of multiple commands into _command_handler In other words, there's no difference between 1 and many commands now * Prettify _command_handler and _login_handler by moving some shared info into instance variables set in `run` * Added some implementation-specific helper functions to the end of the file Is this file getting too cluttered?
screenshot.py wants to `from selenium import` something, so add ka-lite/python-packages to conf.py (for `make` commands) and to the test script (so tests run without import errors). This is dependent on the current directory structure.
The screenshots are collected in a build environment variable and executed as a batch at a certain point in the build process This will significantly decrease the build time.
Prevents a potential error for multiple shots if one fails and the browser remains open.
…lates_script Remove the css classes mistakenly translated.
Sphinx docs
…hlight in perseus.css.
…ng-is-missing-left-border fix for #2980 - Answer box highlighting is missing left border.
Returns keypad to its former stylistic glory
fixed points not shown when logged in as learner. note: html id cannot c...
…able-to-select-one-input Software keypad only able to select one input
…instead of just the tabular report.
docs - screenshot directive (and management command) can take screenshot as though the device was registered
Add FAQ to the docs.
In an ideal world, these could be the same. But we've often needed to do extra stuff on the central-* branches that shouldn't (yet/ever) be in the master/develop branches. For example, the nalanda branch added some models (e.g. AttemptLog) that weren't part of 0.12, but since the nalanda code was being used in production, and needing to sync against the central server, the nalanda branch needed to be merged to central-master (e.g. see master...central-master) Longer-term, we want to have:
Not sure whether this is exactly what you're asking, but yeah, the stuff inside ka-lite is used extensively within ka-lite-central, in particular:
|
…kflow Conflicts: sphinx-docs/index.rst
…h-reports Move `subtitle` css styles to be used by all coach reports templates instead of just the tabular report.
Add workflow for contributing to docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.