Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #2980 - Answer box highlighting is missing left border. #3173

Conversation

djallado
Copy link
Contributor

@djallado djallado commented Mar 3, 2015

Hi. @MCGallaspy. This fixed #2980 - Answer box highlighting is missing left border.

Milestone: 0.14.x
No test for now because this is a simple box-shawdow in css.

Screenshot below:
screen shot high-light

@rtibbles rtibbles added this to the 0.14.x milestone Mar 3, 2015
@rtibbles
Copy link
Member

rtibbles commented Mar 3, 2015

@djallado This looks like the right fix, but would prefer to avoid inline style definitions. Could you put this in khan-lite.css instead?

@rtibbles rtibbles self-assigned this Mar 3, 2015
@djallado
Copy link
Contributor Author

djallado commented Mar 4, 2015

@rtibbles.
No. I doesn't work if we put it in khan-lite.css. khan-lite.css is overridden by /exercise-content-package/perseus.css. As much as possible, I don't want to pollute the perseus.css. So I put inline style definitions just to override the perseus.css.

@rtibbles
Copy link
Member

rtibbles commented Mar 4, 2015

Two options then - we add an exercise.css that we import after perseus.css to overwrite its styles, or we make the selector more specific than the perseus one.

For example:

#content-area .perseus-widget-container.widget-highlight {
    box-shadow: -4px 0 9px 5px #ffa500;
}

Should provide a more specific selector than that provided in perseus.css and hence should override.
Either way, a solution without inline styles is the preferred one.

@rtibbles
Copy link
Member

rtibbles commented Mar 4, 2015

Does the trick. Thanks for fixing up nicely, @djallado!

rtibbles added a commit that referenced this pull request Mar 4, 2015
…ng-is-missing-left-border

fix for #2980 - Answer box highlighting is missing left border.
@rtibbles rtibbles merged commit 799fbc6 into learningequality:develop Mar 4, 2015
@rtibbles rtibbles removed the has PR label Mar 4, 2015
@djallado djallado deleted the hotfix/2980-answer-box-highlighting-is-missing-left-border branch October 26, 2015 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants