Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the css classes mistakenly translated. #3172

Merged
merged 1 commit into from
Mar 3, 2015
Merged

Remove the css classes mistakenly translated. #3172

merged 1 commit into from
Mar 3, 2015

Conversation

arceduardvincent
Copy link
Contributor

Hi @aronasorman and @MCGallaspy -this fixes #3075

I remove the css classes mistakenly translated and revert it to the intended purpose.
I wrapped the css classes in a maker block that can mark this this blocks {% block i18n_do_not_translate %} as not to be translated.
As long as this css classes are mark within this block it will not be translated.

See the implementation and the fix here fle-internal/i18nize_templates#3

/review: @jesumer

@rtibbles
Copy link
Member

rtibbles commented Mar 3, 2015

All the fixes here look good.

rtibbles added a commit that referenced this pull request Mar 3, 2015
@rtibbles
Merge pull request #3172 from mrpau/hotfix/3075-running_i18n-ize_temp…
da4de66 
…lates_script

Remove the css classes mistakenly translated.
@rtibbles rtibbles merged commit da4de66 into learningequality:develop Mar 3, 2015
@rtibbles rtibbles removed the has PR label Mar 3, 2015
@arceduardvincent arceduardvincent deleted the hotfix/3075-running_i18n-ize_templates_script branch March 4, 2015 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arceduardvincent @rtibbles @aronasorman