Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs - screenshot directive (and management command) can take screenshot as though the device was registered #3180

Merged

Conversation

MCGallaspy
Copy link
Contributor

Because previously it couldn't. Does this by creating an associated Zone and DeviceZone for the Device, so that Device.is_registered() returns True.

Also touched up sphinx-docs/screenshot.py a little bit while I was in there, and added the appropriate option to a couple of screenshots.

return new_arg

def _make_image_node(self):
"""Make an image node by safely calling Image.run (i.e. ensure the file exists)."""
self.arguments.append(os.path.join("/", SS_DUMP_DIR, self.filename+".png"))
open(os.path.join(OUTPUT_PATH, self.filename+".png"), 'w').close()

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@aronasorman aronasorman self-assigned this Mar 4, 2015
@aronasorman aronasorman added this to the 0.13.x milestone Mar 4, 2015
aronasorman added a commit that referenced this pull request Mar 9, 2015
docs - screenshot directive (and management command) can take screenshot as though the device was registered
@aronasorman aronasorman merged commit 3932664 into learningequality:develop Mar 9, 2015
@aronasorman aronasorman removed the has PR label Mar 9, 2015
@aronasorman aronasorman deleted the ss-mgmt-registered-feature branch March 9, 2015 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants